From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: andi@rhlx01.fht-esslingen.de, B.Zolnierkiewicz@elka.pw.edu.pl,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipeline stall
Date: Fri, 30 Jun 2006 19:21:39 +0100 [thread overview]
Message-ID: <1151691699.31392.72.camel@localhost.localdomain> (raw)
In-Reply-To: <20060630110018.f45b40e2.akpm@osdl.org>
Ar Gwe, 2006-06-30 am 11:00 -0700, ysgrifennodd Andrew Morton:
> I guess because he was profiling for IFU_MEM_STALL, not for wall-time.
>
> > NAK because
> > 1. This is a gcc problem
> > 2. Not everyone is using an intel x86-32 box which has such problems
> > 3. IDE is in life-support mode and the relatives are already planning
> > the flowers.
>
> Well. If the patch breaks anything we can dine on hats for a month. Seems
> pretty inoffensive to me.
Yeah its a do nothing change that has no value. We can equally not apply
it and see no difference. Its make-work that might slow down some
systems.
Send it to the gcc people see if its a case they could/should optimise
Alan
prev parent reply other threads:[~2006-06-30 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 16:13 [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipeline stall Andreas Mohr
2006-06-30 17:26 ` Alan Cox
2006-06-30 18:00 ` Andrew Morton
2006-06-30 18:21 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151691699.31392.72.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox