From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org,
Catalin Marinas <catalin.marinas@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
Date: Mon, 11 Dec 2006 22:26:25 +0900 [thread overview]
Message-ID: <20061211132625.GA18947@htj.dyndns.org> (raw)
In-Reply-To: <b0943d9e0612091454j6df1fb0ej2fa006c3fa33abae@mail.gmail.com>
piix_init_one() allocates host private data which should be freed by
piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop()
while merging, leaking 4 bytes on driver detach. Fix it.
This was spotted using Kmemleak by Catalin Marinas.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>
---
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index c7de0bb..dfe17e1 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -330,7 +330,7 @@ static const struct ata_port_operations ich_pata_ops = {
.port_start = ata_port_start,
.port_stop = ata_port_stop,
- .host_stop = ata_host_stop,
+ .host_stop = piix_host_stop,
};
static const struct ata_port_operations piix_sata_ops = {
next parent reply other threads:[~2006-12-11 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b0943d9e0612091454j6df1fb0ej2fa006c3fa33abae@mail.gmail.com>
2006-12-11 13:26 ` Tejun Heo [this message]
2006-12-11 14:19 ` [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops Alan
2006-12-13 10:41 ` Catalin Marinas
2006-12-14 23:42 ` Catalin Marinas
2006-12-15 23:14 ` [PATCH] Fix a memory leak in piix_init_one Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211132625.GA18947@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=catalin.marinas@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox