* [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
@ 2007-04-11 15:28 Milind Arun Choudhary
2007-04-11 15:38 ` Alan Cox
2007-04-11 15:44 ` Jan Engelhardt
0 siblings, 2 replies; 3+ messages in thread
From: Milind Arun Choudhary @ 2007-04-11 15:28 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-ide, linux-kernel, akpm, alan
remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
---
pata_winbond.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c
index 6c11103..cfcd2a5 100644
--- a/drivers/ata/pata_winbond.c
+++ b/drivers/ata/pata_winbond.c
@@ -36,7 +36,7 @@ static int probe_winbond = 1;
static int probe_winbond;
#endif
-static spinlock_t winbond_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(winbond_lock);
static void winbond_writecfg(unsigned long port, u8 reg, u8 val)
{
--
Milind Arun Choudhary
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
2007-04-11 15:28 [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Milind Arun Choudhary
@ 2007-04-11 15:38 ` Alan Cox
2007-04-11 15:44 ` Jan Engelhardt
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-04-11 15:38 UTC (permalink / raw)
To: Milind Arun Choudhary
Cc: kernel-janitors, linux-ide, linux-kernel, akpm, alan
On Wed, Apr 11, 2007 at 08:58:46PM +0530, Milind Arun Choudhary wrote:
> remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
>
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
2007-04-11 15:28 [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Milind Arun Choudhary
2007-04-11 15:38 ` Alan Cox
@ 2007-04-11 15:44 ` Jan Engelhardt
1 sibling, 0 replies; 3+ messages in thread
From: Jan Engelhardt @ 2007-04-11 15:44 UTC (permalink / raw)
To: Milind Arun Choudhary
Cc: kernel-janitors, linux-ide, linux-kernel, akpm, alan
On Apr 11 2007 20:58, Milind Arun Choudhary wrote:
>
>remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
Don't we have some more places where spinlocks could be janitorified?
Otherwise, ok!
Jan
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-11 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-11 15:28 [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Milind Arun Choudhary
2007-04-11 15:38 ` Alan Cox
2007-04-11 15:44 ` Jan Engelhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox