[PATCH] AHCI: add Dell PowerEdge SC430 pci id

[PATCH] AHCI: add Dell PowerEdge SC430 pci id

[maximilian attems]

ATA chipset on Dell PowerEdge SC430 is identified as:
00:1f.2 IDE interface [0101]: Intel Corporation 82801GB/GR/GH (ICH7
Family) Serial ATA Storage Controller IDE [8086:27c0] (rev 01)

Kernel load the ahci driver with NCQ support after I added it's
device IDs into ahci.c.

Original patch from Andrew Lee <andrew@linux.org.tw>,
forward ported from http://bugs.debian.org/403189

Cc: Andrew Lee <andrew@linux.org.tw>,
Signed-off-by: maximilian attems <max@stro.at>
---
 drivers/ata/ahci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 97f83fb..15657c9 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -390,6 +390,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	/* Intel */
 	{ PCI_VDEVICE(INTEL, 0x2652), board_ahci }, /* ICH6 */
 	{ PCI_VDEVICE(INTEL, 0x2653), board_ahci }, /* ICH6M */
+	{ PCI_VDEVICE(INTEL, 0x27c0), board_ahci }, /* ICH7 */
 	{ PCI_VDEVICE(INTEL, 0x27c1), board_ahci }, /* ICH7 */
 	{ PCI_VDEVICE(INTEL, 0x27c5), board_ahci }, /* ICH7M */
 	{ PCI_VDEVICE(INTEL, 0x27c3), board_ahci }, /* ICH7R */
-- 
1.5.5.1

Re: [PATCH] AHCI: add Dell PowerEdge SC430 pci id

[Matthew Garrett]

On Thu, May 08, 2008 at 10:40:28PM +0200, maximilian attems wrote:
> ATA chipset on Dell PowerEdge SC430 is identified as:
> 00:1f.2 IDE interface [0101]: Intel Corporation 82801GB/GR/GH (ICH7
> Family) Serial ATA Storage Controller IDE [8086:27c0] (rev 01)
> 
> Kernel load the ahci driver with NCQ support after I added it's
> device IDs into ahci.c.

Please don't do that. The BIOS has programmed the chip into IDE mode, 
not AHCI mode. It seems to have also set up the AHCI BAR, but the 
majority of chips with this ID won't have been and so the ahci driver 
will fail with them. If the chip was in AHCI mode, the device ID would 
automatically have changed to 0x27c1.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] AHCI: add Dell PowerEdge SC430 pci id

[maximilian attems]

On Fri, May 09, 2008 at 12:34:35AM +0100, Matthew Garrett wrote:
> On Thu, May 08, 2008 at 10:40:28PM +0200, maximilian attems wrote:
> > ATA chipset on Dell PowerEdge SC430 is identified as:
> > 00:1f.2 IDE interface [0101]: Intel Corporation 82801GB/GR/GH (ICH7
> > Family) Serial ATA Storage Controller IDE [8086:27c0] (rev 01)
> > 
> > Kernel load the ahci driver with NCQ support after I added it's
> > device IDs into ahci.c.
> 
> Please don't do that. The BIOS has programmed the chip into IDE mode, 
> not AHCI mode. It seems to have also set up the AHCI BAR, but the 
> majority of chips with this ID won't have been and so the ahci driver 
> will fail with them. If the chip was in AHCI mode, the device ID would 
> automatically have changed to 0x27c1.

thanks for the info.