From: David Miller <davem@davemloft.net>
To: khali@linux-fr.org
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] IDE: Silent compiler warning in ide_pio_bytes()
Date: Mon, 22 Jun 2009 16:10:59 -0700 (PDT) [thread overview]
Message-ID: <20090622.161059.69648151.davem@davemloft.net> (raw)
In-Reply-To: <20090622211052.45b3cfc5@hyperion.delvare>
From: Jean Delvare <khali@linux-fr.org>
Date: Mon, 22 Jun 2009 21:10:52 +0200
> PageHighMem() isn't cheap so avoid calling it several times on the
> same page. I had the hope that this would silent the following
> compilation warning:
>
> drivers/ide/ide-taskfile.c: In function 'ide_pio_bytes':
> drivers/ide/ide-taskfile.c:229: warning: 'flags' may be used uninitialized in this function
>
> which is a false positive, but it did not. So let's just initialize the
> flags and be done with it, so that other developers don't waste their
> time looking at it.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Like Borislav, I think it's better to use uninitialized_var().
It describes the situation completely.
Please submit an updated patch, and thank you for this.
next prev parent reply other threads:[~2009-06-22 23:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 19:10 [PATCH] IDE: Silent compiler warning in ide_pio_bytes() Jean Delvare
2009-06-22 20:55 ` Borislav Petkov
2009-06-22 23:10 ` David Miller [this message]
2009-06-23 6:53 ` Jean Delvare
2009-06-23 9:32 ` David Miller
2009-06-23 9:52 ` Jean Delvare
2009-06-23 10:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622.161059.69648151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bzolnier@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox