Re: [PATCH] IDE: Silent compiler warning in ide_pio_bytes()

[Jean Delvare <khali@linux-fr.org>]

Hi Dave, Borislav,

On Mon, 22 Jun 2009 16:10:59 -0700 (PDT), David Miller wrote:
> From: Jean Delvare <khali@linux-fr.org>
> Date: Mon, 22 Jun 2009 21:10:52 +0200
> 
> > PageHighMem() isn't cheap so avoid calling it several times on the
> > same page. I had the hope that this would silent the following
> > compilation warning:
> > 
> > drivers/ide/ide-taskfile.c: In function 'ide_pio_bytes':
> > drivers/ide/ide-taskfile.c:229: warning: 'flags' may be used uninitialized in this function
> > 
> > which is a false positive, but it did not. So let's just initialize the
> > flags and be done with it, so that other developers don't waste their
> > time looking at it.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> 
> Like Borislav, I think it's better to use uninitialized_var().
> It describes the situation completely.
> 
> Please submit an updated patch, and thank you for this.

I fear somebody else will have to do that. I personally think
uninitialized_var() should not have been invented, I don't want to have
my name associated with any of its uses for it will inevitably lead to
bugs in the future.

I'll resubmit a patch not fixing the warning (because the rest is still
useful I think) but that's about all I can offer.

-- 
Jean Delvare