From: David Miller <davem@davemloft.net>
To: mpatocka@redhat.com
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] fix BUG with IDE taskfile ioctl and cfq
Date: Tue, 06 Apr 2010 16:36:35 -0700 (PDT) [thread overview]
Message-ID: <20100406.163635.122075784.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1004061924430.27367@hs20-bc2-1.build.redhat.com>
From: Mikulas Patocka <mpatocka@redhat.com>
Date: Tue, 6 Apr 2010 19:29:57 -0400 (EDT)
> This fixes a crash when using hdparm --security-* on IDE devices with CFQ
> scheduler.
Thanks I'll take a look at a this.
> BTW. I found out that it's impossible to use these security commands on
> sparc64 because of 64-bit kernel, 32-bit userspace and a lack of ioctl
> emulation (I succeeded when I recompiled hdparm on my own in 64-bit mode).
> What do you think is the best fix for it? Put it to fs/compat_ioctl.c
> (like SG_IO)? Or make a compat_ioctl method in IDE? Or don't fix it and
> persuade distros to compile hdparm as 64-bit?
The general pattern is to move the ioctl compat handlers into
the drivers themselves, so putting in a compat handler in the
IDE layer is the way to go.
next prev parent reply other threads:[~2010-04-06 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 23:29 [PATCH] fix BUG with IDE taskfile ioctl and cfq Mikulas Patocka
2010-04-06 23:36 ` David Miller [this message]
2010-04-06 23:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406.163635.122075784.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox