Linux ATA/IDE development
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mpatocka@redhat.com
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] fix BUG with IDE taskfile ioctl and cfq
Date: Tue, 06 Apr 2010 16:45:11 -0700 (PDT)	[thread overview]
Message-ID: <20100406.164511.24613147.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1004061924430.27367@hs20-bc2-1.build.redhat.com>

From: Mikulas Patocka <mpatocka@redhat.com>
Date: Tue, 6 Apr 2010 19:29:57 -0400 (EDT)

> Fix IDE taskfile with cfq scheduler
> 
> When ide taskfile access is being used (for example with hdparm --security
> commands) and cfq scheduler is selected, the scheduler crashes on BUG in
> cfq_put_request.
> 
> The reason is that the cfq scheduler is tracking counts of read and write
> requests separately; the ide-taskfile subsystem allocates a read request and
> then flips the flag to make it a write request. The counters in cfq will
> mismatch.
> 
> This patch changes ide-taskfile to allocate the READ or WRITE request as
> required and don't change the flag later.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Applied and queued up for -stable, thanks again Mikulas.

      parent reply	other threads:[~2010-04-06 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-06 23:29 [PATCH] fix BUG with IDE taskfile ioctl and cfq Mikulas Patocka
2010-04-06 23:36 ` David Miller
2010-04-06 23:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100406.164511.24613147.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox