Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Robin H. Johnson" <robbat2@gentoo.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: provide the ability to disable a disk via the params.
Date: Thu, 12 Dec 2013 08:39:35 -0500	[thread overview]
Message-ID: <20131212133935.GA32683@htj.dyndns.org> (raw)
In-Reply-To: <1386464187-6993-1-git-send-email-robbat2@gentoo.org>

Hello, Robin.

On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote:
> +		{ "disable",	.horkage_on	= ATA_HORKAGE_DISABLE },
> +		{ "nodisable",	.horkage_off	= ATA_HORKAGE_DISABLE },

Given the current usage of ATA_HORKAGE_DISABLE, I don't think we need
"nodisable".  Let's just add "disable" for now.  Can you please update
the patch and resend?

Thanks.

-- 
tejun

  reply	other threads:[~2013-12-12 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08  0:56 [PATCH] libata: provide the ability to disable a disk via the params Robin H. Johnson
2013-12-12 13:39 ` Tejun Heo [this message]
2013-12-12 20:22   ` Robin H. Johnson
2013-12-12 20:36     ` Levente Kurusa
2013-12-12 20:47       ` Robin H. Johnson
2013-12-13 21:15       ` Tejun Heo
2013-12-16 17:31 ` [PATCH v2] libata: disable a disk via libata.force params Robin H. Johnson
2013-12-16 17:43   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212133935.GA32683@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox