From: "Robin H. Johnson" <robbat2@gentoo.org>
To: Tejun Heo <tj@kernel.org>
Cc: "Robin H. Johnson" <robbat2@gentoo.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: provide the ability to disable a disk via the params.
Date: Thu, 12 Dec 2013 20:22:53 +0000 [thread overview]
Message-ID: <robbat2-20131212T200207-028507804Z@orbis-terrarum.net> (raw)
In-Reply-To: <20131212133935.GA32683@htj.dyndns.org>
On Thu, Dec 12, 2013 at 08:39:35AM -0500, Tejun Heo wrote:
> Hello, Robin.
>
> On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote:
> > + { "disable", .horkage_on = ATA_HORKAGE_DISABLE },
> > + { "nodisable", .horkage_off = ATA_HORKAGE_DISABLE },
> Given the current usage of ATA_HORKAGE_DISABLE, I don't think we need
> "nodisable". Let's just add "disable" for now. Can you please update
> the patch and resend?
Before I do so, I have two questions:
1.
Countering your nodisable comment, would it be valid to do:
libata.force=2:disable libata.force=2.02:nodisable
To disable all of port 2 except device 2?
2. One of my friends wondered if it would be worthwhile to add force
keywords for other HORKAGE bits, and if so, should the
ata_lflag/ata_link force bits also be presented?
There are only 3 HORKAGE bits presently available in libata.force:
ATA_HORKAGE_NONCQ
ATA_HORKAGE_DUMP_ID
ATA_HORKAGE_ATAPI_DMADIR
And 3 ata_link flags:
ATA_LFLAG_NO_HRST
ATA_LFLAG_NO_SRST
ATA_LFLAG_RST_ONCE
--
Robin Hugh Johnson
Gentoo Linux: Developer, Infrastructure Lead
E-Mail : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
next prev parent reply other threads:[~2013-12-12 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 0:56 [PATCH] libata: provide the ability to disable a disk via the params Robin H. Johnson
2013-12-12 13:39 ` Tejun Heo
2013-12-12 20:22 ` Robin H. Johnson [this message]
2013-12-12 20:36 ` Levente Kurusa
2013-12-12 20:47 ` Robin H. Johnson
2013-12-13 21:15 ` Tejun Heo
2013-12-16 17:31 ` [PATCH v2] libata: disable a disk via libata.force params Robin H. Johnson
2013-12-16 17:43 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=robbat2-20131212T200207-028507804Z@orbis-terrarum.net \
--to=robbat2@gentoo.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox