From: Tejun Heo <tj@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: Candidate for late revert ?
Date: Mon, 2 Jun 2014 20:45:20 -0400 [thread overview]
Message-ID: <20140603004520.GB19855@htj.dyndns.org> (raw)
In-Reply-To: <yq138fm98in.fsf@sermon.lab.mkp.net>
Hello, Martin.
(cc'ing linux-ide)
On Mon, Jun 02, 2014 at 07:49:52PM -0400, Martin K. Petersen wrote:
> I'm starting to think we'll have to make queued trim an opt-in for
> now. Every vendor appears to screw it up. I had a third patch in my
> series that would allow the users to override the type of trim in
> sysfs. It was mainly written as an aid to the SSD vendors so they could
> test queued trim on drives we had blacklisted. I didn't post it because
> I was afraid people would shoot themselves in the foot. But maybe opt-in
> for enthusiasts is a better approach in the short term...
The problem with that approach is that it's very likely that we won't
be able to take advantage of that feature ever. IIRC, we did a
similar thing with FUA support. We added the support, a bunch of
controllers and devices were broken, we hid it behind a module option
with the goal being eventually developing a whitelist. Of course,
there's no way to actually find out which combinations work once the
feature is disabled by default and libata FUA support is essentially
dead, which BTW might be the right conclusion. It's not like FUA
makes noticeable difference and quite likely that vendors haven't
gotten around to fix the issues anyway and won't ever.
The one difference is that, unlike FUA, queued trim is actually
useful, so I kinda wanna give it more fighting chances before we
declare defeat and bury it behind a module option. That said, I
wouldn't have any problem with applying blacklist liberally for
devices which show any sign of issues. If there isn't no definite
confirmation from the vendor regarding what the issue was and which
firmware fixes it, I think blacklisting the whole family of devices
isn't a bad idea. If this feature is gonna survive, given its actual
usefulness, I think / hope it would, the trade-off of blacklisting
existing devices widely makes pretty good sense if that'd allow us to
salvage the feature in the long term.
So, let's keep blacklisting liberally for now.
Thanks.
--
tejun
next parent reply other threads:[~2014-06-03 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140603000728.28fca8fe@www.etchedpixels.co.uk>
[not found] ` <CA+55aFykTbMRKku1bDd_wHCjyD+Yf2v-B8-c+NKMZ0AnNkpVrw@mail.gmail.com>
[not found] ` <yq138fm98in.fsf@sermon.lab.mkp.net>
2014-06-03 0:45 ` Tejun Heo [this message]
2014-06-03 1:11 ` Candidate for late revert ? Martin K. Petersen
2014-06-03 1:15 ` Tejun Heo
2014-06-03 1:17 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603004520.GB19855@htj.dyndns.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox