Linux ATA/IDE development
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-ide@vger.kernel.org
Subject: Re: Candidate for late revert ?
Date: Mon, 02 Jun 2014 21:11:52 -0400	[thread overview]
Message-ID: <yq1sinm6bl3.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20140603004520.GB19855@htj.dyndns.org> (Tejun Heo's message of "Mon, 2 Jun 2014 20:45:20 -0400")

>>>>> "Tejun" == Tejun Heo <tj@kernel.org> writes:

Tejun> The problem with that approach is that it's very likely that we
Tejun> won't be able to take advantage of that feature ever.

Well, maybe. Ubuntu just turned on discard by default (for better and
worse). Took a while to get here with unqueued trim but it doesn't look
like they've had too much fallout.

The problem with queued trim is that we're in the bootstrap phase,
vendors generally don't have anything to test it with. The ones I talk
to claim that it's not really working in Windows yet. So we're the only
ones that actually support it.

Tejun> That said, I wouldn't have any problem with applying blacklist
Tejun> liberally for devices which show any sign of issues.  If there
Tejun> isn't no definite confirmation from the vendor regarding what the
Tejun> issue was and which firmware fixes it, I think blacklisting the
Tejun> whole family of devices isn't a bad idea.

Yeah. The fun thing in this case is that Micron specifically issued this
firmware release to fix queued trim. And they did test with our code. As
did I. And yet something broke for users.

Tejun> So, let's keep blacklisting liberally for now.

OK. And how do you feel about making a disable/unqueued/queued sysfs
knob? I'd really like to make it easy for the drive vendors to test. And
if we liberally blacklist their firmware releases then we have
significantly raised the barrier for their testing. Because all of a
sudden they need to start mucking with kernel builds instead of booting
the latest $DISTRO Live CD.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2014-06-03  1:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140603000728.28fca8fe@www.etchedpixels.co.uk>
     [not found] ` <CA+55aFykTbMRKku1bDd_wHCjyD+Yf2v-B8-c+NKMZ0AnNkpVrw@mail.gmail.com>
     [not found]   ` <yq138fm98in.fsf@sermon.lab.mkp.net>
2014-06-03  0:45     ` Candidate for late revert ? Tejun Heo
2014-06-03  1:11       ` Martin K. Petersen [this message]
2014-06-03  1:15         ` Tejun Heo
2014-06-03  1:17           ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1sinm6bl3.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox