Linux ATA/IDE development
 help / color / mirror / Atom feed
* [PATCH] ide: Add helper macro for struct pci_driver bolierplate
@ 2015-07-11 10:09 Vaishali Thakkar
  0 siblings, 0 replies; only message in thread
From: Vaishali Thakkar @ 2015-07-11 10:09 UTC (permalink / raw)
  To: David S. Miller; +Cc: linux-ide, linux-kernel

For simple IDE modules that contain a single pci_driver without any
additional setup code then ends up being a block of duplicated
boilerplate. This patch adds a new macro, module_ide_pci_driver(),
which replaces the module_init()/module_exit() registrations with
template functions.

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
 include/linux/ide.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/linux/ide.h b/include/linux/ide.h
index a633898..ac93cf5 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -1189,6 +1189,17 @@ extern int __ide_pci_register_driver(struct pci_driver *driver, struct module *o
 #define ide_pci_register_driver(d) pci_register_driver(d)
 #endif
 
+/**
+ * module_ide_pci_driver() - Helper macro for registering a IDE drivers
+ * @__pci_driver: pci_driver struct
+ * Helper macro for IDE drivers which do not do anything special in module
+ * init/exit. This eliminates a lot of boilerplate. Each module may only
+ * use this macro once, and calling it replaces module_init() and module_exit()
+ */
+#define module_ide_pci_driver(__pci_driver) \
+	module_driver(__pci_driver, ide_pci_register_driver, \
+			pci_unregister_driver)
+
 static inline int ide_pci_is_in_compatibility_mode(struct pci_dev *dev)
 {
 	if ((dev->class >> 8) == PCI_CLASS_STORAGE_IDE && (dev->class & 5) != 5)
-- 
1.9.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-11 10:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-11 10:09 [PATCH] ide: Add helper macro for struct pci_driver bolierplate Vaishali Thakkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox