* [PATCH] ide: use setup_timer
[not found] <0ff6e139159043e3416b0e5bc89e9aa5399bbb8e.1490601847.git.geliangtang@gmail.com>
@ 2017-04-09 1:41 ` Geliang Tang
2017-05-08 21:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2017-04-09 1:41 UTC (permalink / raw)
To: David S. Miller; +Cc: Geliang Tang, linux-ide, linux-kernel
Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/ide/ide-probe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index a74ae8df..0235625 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -1183,9 +1183,7 @@ static void ide_init_port_data(ide_hwif_t *hwif, unsigned int index)
spin_lock_init(&hwif->lock);
- init_timer(&hwif->timer);
- hwif->timer.function = &ide_timer_expiry;
- hwif->timer.data = (unsigned long)hwif;
+ setup_timer(&hwif->timer, &ide_timer_expiry, (unsigned long)hwif);
init_completion(&hwif->gendev_rel_comp);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread