* [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() [not found] <20170817232311.25948-1-bart.vanassche@wdc.com> @ 2017-08-17 23:23 ` Bart Van Assche 2017-08-18 5:00 ` David Miller 2017-08-18 7:39 ` Hannes Reinecke 0 siblings, 2 replies; 3+ messages in thread From: Bart Van Assche @ 2017-08-17 23:23 UTC (permalink / raw) To: Jens Axboe Cc: linux-block, Christoph Hellwig, Bart Van Assche, David S . Miller, linux-ide This patch does not change any functionality. Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: David S. Miller <davem@davemloft.net> Cc: linux-ide@vger.kernel.org --- drivers/ide/ide-floppy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 627b1f62a749..3ddd88219906 100644 --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c @@ -72,7 +72,7 @@ static int ide_floppy_callback(ide_drive_t *drive, int dsc) drive->failed_pc = NULL; if (pc->c[0] == GPCMD_READ_10 || pc->c[0] == GPCMD_WRITE_10 || - (req_op(rq) == REQ_OP_SCSI_IN || req_op(rq) == REQ_OP_SCSI_OUT)) + blk_rq_is_scsi(rq)) uptodate = 1; /* FIXME */ else if (pc->c[0] == GPCMD_REQUEST_SENSE) { -- 2.14.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() 2017-08-17 23:23 ` [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() Bart Van Assche @ 2017-08-18 5:00 ` David Miller 2017-08-18 7:39 ` Hannes Reinecke 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2017-08-18 5:00 UTC (permalink / raw) To: bart.vanassche; +Cc: axboe, linux-block, hch, linux-ide From: Bart Van Assche <bart.vanassche@wdc.com> Date: Thu, 17 Aug 2017 16:23:07 -0700 > This patch does not change any functionality. > > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Acked-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() 2017-08-17 23:23 ` [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() Bart Van Assche 2017-08-18 5:00 ` David Miller @ 2017-08-18 7:39 ` Hannes Reinecke 1 sibling, 0 replies; 3+ messages in thread From: Hannes Reinecke @ 2017-08-18 7:39 UTC (permalink / raw) To: Bart Van Assche, Jens Axboe Cc: linux-block, Christoph Hellwig, David S . Miller, linux-ide On 08/18/2017 01:23 AM, Bart Van Assche wrote: > This patch does not change any functionality. > > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: linux-ide@vger.kernel.org > --- > drivers/ide/ide-floppy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c > index 627b1f62a749..3ddd88219906 100644 > --- a/drivers/ide/ide-floppy.c > +++ b/drivers/ide/ide-floppy.c > @@ -72,7 +72,7 @@ static int ide_floppy_callback(ide_drive_t *drive, int dsc) > drive->failed_pc = NULL; > > if (pc->c[0] == GPCMD_READ_10 || pc->c[0] == GPCMD_WRITE_10 || > - (req_op(rq) == REQ_OP_SCSI_IN || req_op(rq) == REQ_OP_SCSI_OUT)) > + blk_rq_is_scsi(rq)) > uptodate = 1; /* FIXME */ > else if (pc->c[0] == GPCMD_REQUEST_SENSE) { > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-18 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170817232311.25948-1-bart.vanassche@wdc.com>
2017-08-17 23:23 ` [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() Bart Van Assche
2017-08-18 5:00 ` David Miller
2017-08-18 7:39 ` Hannes Reinecke
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox