From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: linux-pci@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bcm-kernel-feedback-list@broadcom.com,
Jens Axboe <axboe@kernel.dk>,
Philipp Zabel <p.zabel@pengutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller
Date: Tue, 16 Jun 2020 17:04:51 -0500 [thread overview]
Message-ID: <20200616220451.GA1983693@bjorn-Precision-5520> (raw)
In-Reply-To: <20200616205533.3513-3-james.quinlan@broadcom.com>
On Tue, Jun 16, 2020 at 04:55:09PM -0400, Jim Quinlan wrote:
> From: Jim Quinlan <jquinlan@broadcom.com>
>
> A reset controller "rescal" is shared between the AHCI driver and the PCIe
> driver for the BrcmSTB 7216 chip. The code is modified to allow this
> sharing and to deassert() properly.
Use imperative mood, e.g.,
A reset controller "rescal" is shared between the AHCI driver and
the PCIe driver for the BrcmSTB 7216 chip. Use
devm_reset_control_get_optional_shared control() to handle this
sharing.
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
>
> Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting")
> Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller
> name")
Don't wrap "Fixes:" lines so it's easier to search for them.
prev parent reply other threads:[~2020-06-16 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 20:55 [PATCH v5 00/12] PCI: brcmstb: enable PCIe for STB chips Jim Quinlan
2020-06-16 20:55 ` [PATCH v5 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller Jim Quinlan
2020-06-16 22:04 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616220451.GA1983693@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=axboe@kernel.dk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox