From: Christoph Hellwig <hch@lst.de>
To: Ondrej Zary <linux@zary.sk>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>,
linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_parport: second preview
Date: Tue, 22 Feb 2022 09:35:25 +0100 [thread overview]
Message-ID: <20220222083525.GB5899@lst.de> (raw)
In-Reply-To: <20220220224909.8032-1-linux@zary.sk>
On Sun, Feb 20, 2022 at 11:49:09PM +0100, Ondrej Zary wrote:
> Protocol registration could be improved - I don't like protocols[] and
> protocol numbers, devices should probably be created by protocol name.
> Also the LPT port base addresses should probably be replaced by port names
> (like parport0).
>
> The bpck driver seems to need to know if a CD drive is attached (weird) but
> I doubt that I can get such info from libata.
You can check adev->class == ATA_DEV_ATAPI, there's a bunch of drivers
that already do that.
I'll try to take a look at the actual patch once I find a bit of time.
prev parent reply other threads:[~2022-02-22 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 22:49 [PATCH] pata_parport: second preview Ondrej Zary
2022-02-21 0:05 ` Damien Le Moal
2022-02-22 8:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222083525.GB5899@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox