From: Tyler Erickson <tyler.erickson@seagate.com>
To: damien.lemoal@opensource.wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
muhammad.ahmad@seagate.com, tyler.erickson@seagate.com,
stable@vger.kernel.org
Subject: [PATCH v2 2/3] libata: fix translation of concurrent positioning ranges
Date: Thu, 2 Jun 2022 16:51:12 -0600 [thread overview]
Message-ID: <20220602225113.10218-3-tyler.erickson@seagate.com> (raw)
In-Reply-To: <20220602225113.10218-1-tyler.erickson@seagate.com>
Fixing the page length in the SCSI translation for the concurrent
positioning ranges VPD page. It was writing starting in offset 3
rather than offset 2 where the MSB is supposed to start for
the VPD page length.
Cc: stable@vger.kernel.org
Fixes: fe22e1c2f705 ("libata: support concurrent positioning ranges log")
Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com>
Reviewed-by: Muhammad Ahmad <muhammad.ahmad@seagate.com>
Tested-by: Michael English <michael.english@seagate.com>
---
drivers/ata/libata-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 42cecf95a4e5..86dbb1cdfabd 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2125,7 +2125,7 @@ static unsigned int ata_scsiop_inq_b9(struct ata_scsi_args *args, u8 *rbuf)
/* SCSI Concurrent Positioning Ranges VPD page: SBC-5 rev 1 or later */
rbuf[1] = 0xb9;
- put_unaligned_be16(64 + (int)cpr_log->nr_cpr * 32 - 4, &rbuf[3]);
+ put_unaligned_be16(64 + (int)cpr_log->nr_cpr * 32 - 4, &rbuf[2]);
for (i = 0; i < cpr_log->nr_cpr; i++, desc += 32) {
desc[0] = cpr_log->cpr[i].num;
--
2.17.1
next prev parent reply other threads:[~2022-06-02 22:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 22:51 [PATCH v2 0/3] ata,sd: Fix reading concurrent positioning ranges Tyler Erickson
2022-06-02 22:51 ` [PATCH v2 1/3] libata: fix reading concurrent positioning ranges log Tyler Erickson
2022-06-03 6:17 ` Hannes Reinecke
2022-06-03 7:07 ` Damien Le Moal
2022-06-03 7:42 ` Hannes Reinecke
2022-06-03 8:18 ` Damien Le Moal
2022-06-02 22:51 ` Tyler Erickson [this message]
2022-06-03 6:18 ` [PATCH v2 2/3] libata: fix translation of concurrent positioning ranges Hannes Reinecke
2022-06-02 22:51 ` [PATCH v2 3/3] scsi: sd: Fix interpretation of VPD B9h length Tyler Erickson
2022-06-03 1:30 ` Damien Le Moal
2022-06-07 0:44 ` Damien Le Moal
2022-06-03 6:18 ` Hannes Reinecke
2022-06-03 1:30 ` [PATCH v2 0/3] ata,sd: Fix reading concurrent positioning ranges Damien Le Moal
2022-06-03 5:23 ` Christoph Hellwig
2022-06-03 5:29 ` Damien Le Moal
2022-06-08 2:27 ` Martin K. Petersen
2022-06-08 3:20 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602225113.10218-3-tyler.erickson@seagate.com \
--to=tyler.erickson@seagate.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=muhammad.ahmad@seagate.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox