From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Tyler Erickson <tyler.erickson@seagate.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
muhammad.ahmad@seagate.com
Subject: Re: [PATCH v2 0/3] ata,sd: Fix reading concurrent positioning ranges
Date: Wed, 8 Jun 2022 12:20:14 +0900 [thread overview]
Message-ID: <d20bc449-874d-a133-6f16-ef6c02732d6f@opensource.wdc.com> (raw)
In-Reply-To: <20220602225113.10218-1-tyler.erickson@seagate.com>
On 6/3/22 07:51, Tyler Erickson wrote:
> This patch series fixes reading the concurrent positioning ranges.
>
> The first patch fixes reading this in libata, where it was reading
> more data than a drive necessarily supports, resulting in a
> command abort.
>
> The second patch fixes the SCSI translated data to put the VPD page
> length in the correct starting byte.
>
> The third patch in sd, the fix is adding 4 instead of 3 for the header
> length. Using 3 will always result in an error and was likely used
> incorrectly as T10 specifications list all tables starting at byte 0,
> and byte 3 is the page length, which would mean there are 4 total
> bytes before the remaining data that contains the ranges and other
> information.
>
> Tyler Erickson (3):
> libata: fix reading concurrent positioning ranges log
> libata: fix translation of concurrent positioning ranges
> scsi: sd: Fix interpretation of VPD B9h length
Applied 1-2 to for-5.19-fixes. Thanks !
>
> drivers/ata/libata-core.c | 21 +++++++++++++--------
> drivers/ata/libata-scsi.c | 2 +-
> drivers/scsi/sd.c | 2 +-
> 3 files changed, 15 insertions(+), 10 deletions(-)
>
>
> base-commit: 700170bf6b4d773e328fa54ebb70ba444007c702
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-06-08 6:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 22:51 [PATCH v2 0/3] ata,sd: Fix reading concurrent positioning ranges Tyler Erickson
2022-06-02 22:51 ` [PATCH v2 1/3] libata: fix reading concurrent positioning ranges log Tyler Erickson
2022-06-03 6:17 ` Hannes Reinecke
2022-06-03 7:07 ` Damien Le Moal
2022-06-03 7:42 ` Hannes Reinecke
2022-06-03 8:18 ` Damien Le Moal
2022-06-02 22:51 ` [PATCH v2 2/3] libata: fix translation of concurrent positioning ranges Tyler Erickson
2022-06-03 6:18 ` Hannes Reinecke
2022-06-02 22:51 ` [PATCH v2 3/3] scsi: sd: Fix interpretation of VPD B9h length Tyler Erickson
2022-06-03 1:30 ` Damien Le Moal
2022-06-07 0:44 ` Damien Le Moal
2022-06-03 6:18 ` Hannes Reinecke
2022-06-03 1:30 ` [PATCH v2 0/3] ata,sd: Fix reading concurrent positioning ranges Damien Le Moal
2022-06-03 5:23 ` Christoph Hellwig
2022-06-03 5:29 ` Damien Le Moal
2022-06-08 2:27 ` Martin K. Petersen
2022-06-08 3:20 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20bc449-874d-a133-6f16-ef6c02732d6f@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=muhammad.ahmad@seagate.com \
--cc=tyler.erickson@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox