public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org,
	"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>
Cc: Hannes Reinecke <hare@suse.de>
Subject: [PATCH v2 2/3] ata: libata: blacklist FUA support for known buggy drives
Date: Mon, 24 Oct 2022 16:26:08 +0900	[thread overview]
Message-ID: <20221024072609.346502-3-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20221024072609.346502-1-damien.lemoal@opensource.wdc.com>

Thread [1] reported back in 2012 problems with enabling FUA for 3
different drives. Add these drives to ata_device_blacklist[] to mark
them with the ATA_HORKAGE_NO_FUA flag. To be conservative and avoid
rpoblems on old systems, the model number for the three new entries
are defined as to widely match all drives in the same product line.

[1]: https://lore.kernel.org/lkml/CA+6av4=uxu_q5U_46HtpUt=FSgbh3pZuAEY54J5_xK=MKWq-YQ@mail.gmail.com/

Suggested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 6008f7ed1c42..27aec8e63a8c 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4128,6 +4128,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 
 	/* Buggy FUA */
 	{ "Maxtor",		"BANC1G10",	ATA_HORKAGE_NO_FUA },
+	{ "WDC*WD2500J*",	NULL,		ATA_HORKAGE_NO_FUA },
+	{ "OCZ-VERTEX*",	NULL,		ATA_HORKAGE_NO_FUA },
+	{ "INTEL*SSDSC2CT*",	NULL,		ATA_HORKAGE_NO_FUA },
 
 	/* End Marker */
 	{ }
-- 
2.37.3


  parent reply	other threads:[~2022-10-24  7:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  7:26 [PATCH v2 0/3] Improve libata support for FUA Damien Le Moal
2022-10-24  7:26 ` [PATCH v2 1/3] ata: libata: cleanup fua handling Damien Le Moal
2022-10-24  7:26 ` Damien Le Moal [this message]
2022-10-24  7:52   ` [PATCH v2 2/3] ata: libata: blacklist FUA support for known buggy drives Hannes Reinecke
2022-10-24  7:26 ` [PATCH v2 3/3] ata: libata: Enable fua support by default Damien Le Moal
2022-10-24 10:16   ` Sergey Shtylyov
2022-10-24 11:15     ` Damien Le Moal
2022-10-24 18:48 ` [PATCH v2 0/3] Improve libata support for FUA Maciej S. Szmigiero
2022-10-24 22:09   ` Damien Le Moal
2022-10-24 23:26     ` Damien Le Moal
2022-10-25  0:22       ` Damien Le Moal
2022-10-25  7:05       ` Hannes Reinecke
2022-10-25  8:59         ` Damien Le Moal
2022-10-25  9:41           ` Niklas Cassel
2022-10-25 18:13           ` Maciej S. Szmigiero
2022-10-25 23:21             ` Damien Le Moal
2022-10-25  9:01         ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024072609.346502-3-damien.lemoal@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox