[PATCH v2] ata: pata_macio: Fix PCI region leak

[PATCH v2] ata: pata_macio: Fix PCI region leak

[Philipp Stanner]

pci_request_regions() became a managed devres functions if the PCI
device was enabled with pcim_enable_device(), which is the case for
pata_macio.

The PCI subsystem recently removed this hybrid feature from
pci_request_region(). When doing so, pata_macio was forgotten to be
ported to use pcim_request_all_regions(). If that function is not used,
pata_macio will fail on driver-reload because the PCI regions will
remain blocked.

Fix the region leak by replacing pci_request_regions() with its managed
counterpart, pcim_request_all_regions().

Fixes: 51f6aec99cb0 ("PCI: Remove hybrid devres nature from request functions")
Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
Changes in v2:
  - Add Fixes: tag and rephrase commit message, since the merge window
    closed already. (Niklas)
---
 drivers/ata/pata_macio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index fbf5f07ea357..f7a933eefe05 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1298,7 +1298,7 @@ static int pata_macio_pci_attach(struct pci_dev *pdev,
 	priv->dev = &pdev->dev;
 
 	/* Get MMIO regions */
-	if (pci_request_regions(pdev, "pata-macio")) {
+	if (pcim_request_all_regions(pdev, "pata-macio")) {
 		dev_err(&pdev->dev,
 			"Cannot obtain PCI resources\n");
 		return -EBUSY;
-- 
2.49.0

Re: [PATCH v2] ata: pata_macio: Fix PCI region leak

[Philipp Stanner]

On Tue, 2025-06-10 at 15:54 +0200, Philipp Stanner wrote:
> pci_request_regions() became a managed devres functions if the PCI
> device was enabled with pcim_enable_device(), which is the case for
> pata_macio.
> 
> The PCI subsystem recently removed this hybrid feature from
> pci_request_region(). When doing so, pata_macio was forgotten to be
> ported to use pcim_request_all_regions(). If that function is not
> used,
> pata_macio will fail on driver-reload because the PCI regions will
> remain blocked.
> 
> Fix the region leak by replacing pci_request_regions() with its
> managed
> counterpart, pcim_request_all_regions().
> 
> Fixes: 51f6aec99cb0 ("PCI: Remove hybrid devres nature from request
> functions")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>

Forgot Damien's Reviewed-by.

P.

> ---
> Changes in v2:
>   - Add Fixes: tag and rephrase commit message, since the merge
> window
>     closed already. (Niklas)
> ---
>  drivers/ata/pata_macio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index fbf5f07ea357..f7a933eefe05 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -1298,7 +1298,7 @@ static int pata_macio_pci_attach(struct pci_dev
> *pdev,
>  	priv->dev = &pdev->dev;
>  
>  	/* Get MMIO regions */
> -	if (pci_request_regions(pdev, "pata-macio")) {
> +	if (pcim_request_all_regions(pdev, "pata-macio")) {
>  		dev_err(&pdev->dev,
>  			"Cannot obtain PCI resources\n");
>  		return -EBUSY;

Re: [PATCH v2] ata: pata_macio: Fix PCI region leak

[Sathyanarayanan Kuppuswamy]

On 6/10/25 6:54 AM, Philipp Stanner wrote:
> pci_request_regions() became a managed devres functions if the PCI
> device was enabled with pcim_enable_device(), which is the case for
> pata_macio.
>
> The PCI subsystem recently removed this hybrid feature from
> pci_request_region(). When doing so, pata_macio was forgotten to be
> ported to use pcim_request_all_regions(). If that function is not used,
> pata_macio will fail on driver-reload because the PCI regions will
> remain blocked.
>
> Fix the region leak by replacing pci_request_regions() with its managed
> counterpart, pcim_request_all_regions().
>
> Fixes: 51f6aec99cb0 ("PCI: Remove hybrid devres nature from request functions")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

> Changes in v2:
>    - Add Fixes: tag and rephrase commit message, since the merge window
>      closed already. (Niklas)
> ---
>   drivers/ata/pata_macio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index fbf5f07ea357..f7a933eefe05 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -1298,7 +1298,7 @@ static int pata_macio_pci_attach(struct pci_dev *pdev,
>   	priv->dev = &pdev->dev;
>   
>   	/* Get MMIO regions */
> -	if (pci_request_regions(pdev, "pata-macio")) {
> +	if (pcim_request_all_regions(pdev, "pata-macio")) {
>   		dev_err(&pdev->dev,
>   			"Cannot obtain PCI resources\n");
>   		return -EBUSY;

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

Re: [PATCH v2] ata: pata_macio: Fix PCI region leak

[Andy Shevchenko]

On Tue, Jun 10, 2025 at 04:01:43PM +0200, Philipp Stanner wrote:
> On Tue, 2025-06-10 at 15:54 +0200, Philipp Stanner wrote:
> > pci_request_regions() became a managed devres functions if the PCI
> > device was enabled with pcim_enable_device(), which is the case for
> > pata_macio.
> > 
> > The PCI subsystem recently removed this hybrid feature from
> > pci_request_region(). When doing so, pata_macio was forgotten to be
> > ported to use pcim_request_all_regions(). If that function is not
> > used,
> > pata_macio will fail on driver-reload because the PCI regions will
> > remain blocked.
> > 
> > Fix the region leak by replacing pci_request_regions() with its
> > managed
> > counterpart, pcim_request_all_regions().
> > 
> > Fixes: 51f6aec99cb0 ("PCI: Remove hybrid devres nature from request
> > functions")
> > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> 
> Forgot Damien's Reviewed-by.

Then put it here, if maintainers use `b4`, it will automatically harvest them.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] ata: pata_macio: Fix PCI region leak

[Niklas Cassel]

On Tue, 10 Jun 2025 15:54:14 +0200, Philipp Stanner wrote:
> pci_request_regions() became a managed devres functions if the PCI
> device was enabled with pcim_enable_device(), which is the case for
> pata_macio.
> 
> The PCI subsystem recently removed this hybrid feature from
> pci_request_region(). When doing so, pata_macio was forgotten to be
> ported to use pcim_request_all_regions(). If that function is not used,
> pata_macio will fail on driver-reload because the PCI regions will
> remain blocked.
> 
> [...]

Applied to libata/linux.git (for-6.16-fixes), thanks!

[1/1] ata: pata_macio: Fix PCI region leak
      https://git.kernel.org/libata/linux/c/3e537877

Kind regards,
Niklas