public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ata: ahci: Disallow LPM for Asus B550-F motherboard
@ 2025-06-17 12:15 Mikko Korhonen
  2025-06-17 12:30 ` Niklas Cassel
  0 siblings, 1 reply; 2+ messages in thread
From: Mikko Korhonen @ 2025-06-17 12:15 UTC (permalink / raw)
  To: Niklas Cassel, Damien Le Moal, linux-ide; +Cc: Mikko Korhonen

Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some
SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0)
when LPM is enabled. Disabling LPM solves the issue.

Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
---
I think we might include the comment about the non working drive model, as
we have tested only one model and in principle this could also be an
interoperation issue. If one would need to enable LPM for the motherboard
and happens to have a working hard drive model, he/she would know
why we have made the patch in the first place.

Changes since v1:
- Fix typo and one line comment style issue.

 drivers/ata/ahci.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index c8ad8ace7496..b9b8ee356fcd 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1454,6 +1454,21 @@ static bool ahci_broken_lpm(struct pci_dev *pdev)
 			},
 			/* 320 is broken, there is no known good version yet. */
 		},
+		{
+			/*
+			 * AMD 500 Series Chipset SATA Controller [1022:43eb]
+			 * on this motherboard timouts on ports 5 and 6
+			 * when LPM enabled at least with WDC WD20EFAX-68FB5N0
+			 * hard drives.
+			 */
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR,
+					"ASUSTeK COMPUTER INC."),
+				DMI_MATCH(DMI_BOARD_NAME,
+					"ROG STRIX B550-F GAMING (WI-FI)"),
+			},
+			/* 3621 is broken, there is no known good version. */
+		},
 		{ }	/* terminate list */
 	};
 	const struct dmi_system_id *dmi = dmi_first_match(sysids);
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ata: ahci: Disallow LPM for Asus B550-F motherboard
  2025-06-17 12:15 [PATCH v2] ata: ahci: Disallow LPM for Asus B550-F motherboard Mikko Korhonen
@ 2025-06-17 12:30 ` Niklas Cassel
  0 siblings, 0 replies; 2+ messages in thread
From: Niklas Cassel @ 2025-06-17 12:30 UTC (permalink / raw)
  To: Mikko Korhonen; +Cc: Damien Le Moal, linux-ide

Hello Mikko,

On Tue, Jun 17, 2025 at 03:15:48PM +0300, Mikko Korhonen wrote:
> Asus ROG STRIX B550-F GAMING (WI-FI) motherboard has problems on some
> SATA ports with at least one hard drive model (WDC WD20EFAX-68FB5N0)
> when LPM is enabled. Disabling LPM solves the issue.
> 
> Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
> ---
> I think we might include the comment about the non working drive model, as
> we have tested only one model and in principle this could also be an
> interoperation issue. If one would need to enable LPM for the motherboard
> and happens to have a working hard drive model, he/she would know
> why we have made the patch in the first place.
> 
> Changes since v1:
> - Fix typo and one line comment style issue.
>

I have already applied your patch:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/commit/?h=for-6.16-fixes&id=a7b3b77fd111d49f8e25624e4ea1046322a57baf


Kind regards,
Niklas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-17 12:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 12:15 [PATCH v2] ata: ahci: Disallow LPM for Asus B550-F motherboard Mikko Korhonen
2025-06-17 12:30 ` Niklas Cassel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox