* [PATCH] ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8
@ 2026-11-16 20:54 Justinien Bouron
2026-11-16 21:00 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Justinien Bouron @ 2026-11-16 20:54 UTC (permalink / raw)
To: Damien Le Moal, Niklas Cassel, Johannes Thumshirn,
Martin K . Petersen, John Garry, Hannes Reinecke, Jens Axboe,
linux-ide, linux-kernel
Cc: Justinien Bouron, Gunnar Kudrjavets, stable
INTEL SSDSCKKB240G8 with firmware version XC311102 runs into FPDMA
timeout errors when queue/max_sectors_kb is set to
BLK_DEF_MAX_SECTORS_CAP = 4096KiB / 8192 sectors. Similar to model
SSDSC2KG480G8, the issue disappears when setting this max size to 8191
sectors, thus apply the same quirk.
Firmware version X5A1ME59 for SSDSCKKB240G8 is un-affected by this bug
thus keep the quirk specific to firmware XC311102.
Fixes: 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP")
Signed-off-by: Justinien Bouron <jbouron@amazon.com>
Reviewed-by: Gunnar Kudrjavets <gunnarku@amazon.com>
Cc: stable@vger.kernel.org
---
drivers/ata/libata-core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 5ff45a5cbfe4a..2a5ca1b9ee5c0 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4204,6 +4204,7 @@ static const struct ata_dev_quirk_value __ata_dev_max_sec_quirks[] = {
{ "LITEON EP1-*", NULL, 1024 },
{ "DELLBOSS VD", "MV.R00-0", 8191 },
{ "INTEL SSDSC2KG480G8", "XCV10120", 8191 },
+ { "INTEL SSDSCKKB240G8", "XC311102", 8191 },
{ },
};
@@ -4474,6 +4475,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
ATA_QUIRK_MAX_SEC },
{ "INTEL*SSDSC2CT*", NULL, ATA_QUIRK_ZERO_AFTER_TRIM |
ATA_QUIRK_NO_FUA },
+ { "INTEL SSDSCKKB240G8", "XC311102", ATA_QUIRK_ZERO_AFTER_TRIM |
+ ATA_QUIRK_MAX_SEC },
{ "INTEL*SSD*", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
{ "SSD*INTEL*", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
{ "Samsung*SSD*", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8
2026-11-16 20:54 [PATCH] ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8 Justinien Bouron
@ 2026-11-16 21:00 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-16 21:00 UTC (permalink / raw)
To: Justinien Bouron, linux-ide; +Cc: dlemoal, cassel
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] ata: libata: quirk shadowing in ata_dev_quirks() [1]
--
commit 139b2f80d245bb5cb2eb4919933ec350b21131cd
Author: Justinien Bouron <jbouron@amazon.com>
ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8
This commit adds an 8191 max_sectors quirk for INTEL SSDSCKKB240G8 drives
with firmware XC311102 to avoid FPDMA timeout errors.
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 5ff45a5cbfe4a..2a5ca1b9ee5c0 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
[ ... ]
> @@ -4474,6 +4475,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
> ATA_QUIRK_MAX_SEC },
> { "INTEL*SSDSC2CT*", NULL, ATA_QUIRK_ZERO_AFTER_TRIM |
> ATA_QUIRK_NO_FUA },
> + { "INTEL SSDSCKKB240G8", "XC311102", ATA_QUIRK_ZERO_AFTER_TRIM |
> + ATA_QUIRK_MAX_SEC },
[Severity: High]
This problem wasn't introduced by this patch, but does the early exact match
in __ata_dev_quirks[] shadow the later wildcard entries for
WDC WD2500JD-00HBB0 and WDC WD3200JD-00KLB0 [1]?
Because ata_dev_quirks() returns on the first matching entry in
__ata_dev_quirks[], this new entry includes ATA_QUIRK_ZERO_AFTER_TRIM ahead
of the INTEL*SSD* wildcard. Earlier in the same table, the exact-match
entries for WDC WD3200JD-00KLB0 and WDC WD2500JD-00HBB0 specify only
ATA_QUIRK_BROKEN_HPA:
drivers/ata/libata-core.c:__ata_dev_quirks[] = {
...
{ "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_QUIRK_BROKEN_HPA },
{ "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_QUIRK_BROKEN_HPA },
...
{ "WDC WD2500JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM |
ATA_QUIRK_NO_FUA },
{ "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
{ "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
...
};
When either drive matches its exact entry, ata_dev_quirks() returns without
reaching the WDC WD2500JD-* or WDC WD3200JD-* wildcard entries, leaving
ATA_QUIRK_WD_BROKEN_LPM and ATA_QUIRK_NO_FUA unapplied and exposing those
drives to broken LPM link instability and unsupported FUA I/O errors.
[1] https://sashiko.dev/#/bug/linux-1d8177db-a3fc-48ef-adce-d0515b20b43a
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116205430.44305-1-jbouron@amazon.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 20:54 [PATCH] ata: libata-core: Add max sector quirk to INTEL SSDSCKKB240G8 Justinien Bouron
2026-11-16 21:00 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox