* [linux-next PATCH] ata: sata_fsl: fix a compile error
@ 2020-03-25 23:59 Li Yang
2020-03-26 9:06 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Li Yang @ 2020-03-25 23:59 UTC (permalink / raw)
To: Jens Axboe; +Cc: Hannes Reinecke, linux-ide, linux-kernel, Li Yang
drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
^
Fixes: b3f06231 ("sata_fsl: move DPRINTK to ata debugging")
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---
drivers/ata/sata_fsl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 45c15c4e9f8a..c43a97d63e6c 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1340,6 +1340,7 @@ static int sata_fsl_init_controller(struct ata_host *host)
{
struct sata_fsl_host_priv *host_priv = host->private_data;
void __iomem *hcr_base = host_priv->hcr_base;
+ struct ata_port *ap = host->ports[0];
u32 temp;
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [linux-next PATCH] ata: sata_fsl: fix a compile error
2020-03-25 23:59 [linux-next PATCH] ata: sata_fsl: fix a compile error Li Yang
@ 2020-03-26 9:06 ` Sergei Shtylyov
2020-03-26 15:17 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2020-03-26 9:06 UTC (permalink / raw)
To: Li Yang, Jens Axboe; +Cc: Hannes Reinecke, linux-ide, linux-kernel
Hello!
On 26.03.2020 2:59, Li Yang wrote:
> drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
> drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
> ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
> ^
Another fix has been posted yesterday.
> Fixes: b3f06231 ("sata_fsl: move DPRINTK to ata debugging")
12 digits SHA1 is needed here.
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [linux-next PATCH] ata: sata_fsl: fix a compile error
2020-03-26 9:06 ` Sergei Shtylyov
@ 2020-03-26 15:17 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-03-26 15:17 UTC (permalink / raw)
To: Sergei Shtylyov, Li Yang; +Cc: Hannes Reinecke, linux-ide, linux-kernel
On 3/26/20 3:06 AM, Sergei Shtylyov wrote:
> Hello!
>
> On 26.03.2020 2:59, Li Yang wrote:
>
>> drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
>> drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
>> ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
> > ^
>
> Another fix has been posted yesterday.
I also dropped the series yesterday, so we don't need any of these
patches anymore.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-26 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-25 23:59 [linux-next PATCH] ata: sata_fsl: fix a compile error Li Yang
2020-03-26 9:06 ` Sergei Shtylyov
2020-03-26 15:17 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox