From: Jeff Garzik <jgarzik@pobox.com>
To: Jens Axboe <axboe@suse.de>
Cc: Daniela Engert <dani@ngrt.de>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
meissner@suse.de
Subject: Re: sata_sil problem / oops
Date: Thu, 02 Jun 2005 17:45:14 -0400 [thread overview]
Message-ID: <429F7DEA.9050506@pobox.com> (raw)
In-Reply-To: <20050602193037.GB13964@suse.de>
Jens Axboe wrote:
> Seems that is so, from looking at the driver. If I were to guess at a
> fix for this, it would be as follows.
>
> diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c
> --- a/drivers/scsi/sata_sil.c
> +++ b/drivers/scsi/sata_sil.c
> @@ -432,7 +432,13 @@ static int sil_init_one (struct pci_dev
> writeb(cls, mmio_base + SIL_FIFO_R0);
> writeb(cls, mmio_base + SIL_FIFO_W0);
> writeb(cls, mmio_base + SIL_FIFO_R1);
> - writeb(cls, mmio_base + SIL_FIFO_W2);
> + writeb(cls, mmio_base + SIL_FIFO_W1);
> + if (ent->driver_data == sil_3114) {
> + writeb(cls, mmio_base + SIL_FIFO_R2);
> + writeb(cls, mmio_base + SIL_FIFO_W2);
> + writeb(cls, mmio_base + SIL_FIFO_R3);
> + writeb(cls, mmio_base + SIL_FIFO_W3);
> + }
This definitely looks like a needed fix to me.
Can someone confirm that this fixes the reported problem?
Jeff
next prev parent reply other threads:[~2005-06-02 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 10:03 sata_sil problem / oops Marcus Meissner
2005-06-02 17:24 ` Daniela Engert
2005-06-02 19:23 ` Jens Axboe
2005-06-02 19:30 ` Jens Axboe
2005-06-02 21:45 ` Jeff Garzik [this message]
2005-06-02 19:50 ` Daniela Engert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429F7DEA.9050506@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=dani@ngrt.de \
--cc=linux-ide@vger.kernel.org \
--cc=meissner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox