From: Arnd Bergmann <arnd@arndb.de>
To: "Måns Rullgård" <mans@mansr.com>
Cc: Tejun Heo <tj@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: dwc: add DMADEVICES dependency
Date: Wed, 11 May 2016 15:13:22 +0200 [thread overview]
Message-ID: <4546329.1O9421M58I@wuerfel> (raw)
In-Reply-To: <yw1xh9e4hhwb.fsf@unicorn.mansr.com>
On Wednesday 11 May 2016 13:57:08 Måns Rullgård wrote:
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index 41b0725e58ad..8f7a4a4d2566 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -322,7 +322,7 @@ config SATA_DWC
> >
> > config SATA_DWC_OLD_DMA
> > bool "Support old device trees"
> > - depends on SATA_DWC
> > + depends on SATA_DWC && DMADEVICES
> > select DW_DMAC_CORE
> > default y if 460EX
> > help
> > --
>
> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES?
No, all dmaengine drivers depend on DMADEVICES, so that would
cause a circular dependency.
The normal behavior for DMA slave drivers is to use the generic
DMA API and have a dependency on DMADEVICES but not on a particular
DMA engine implementation. In this case, the driver uses an exported
interface of the dw_dma driver directly, so we also need to select
that one, but it doesn't mean we can skip the normal dependency.
Arnd
next prev parent reply other threads:[~2016-05-11 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 12:44 [PATCH] ata: dwc: add DMADEVICES dependency Arnd Bergmann
2016-05-11 12:57 ` Måns Rullgård
2016-05-11 13:13 ` Arnd Bergmann [this message]
2016-05-11 13:19 ` Måns Rullgård
2016-05-11 13:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4546329.1O9421M58I@wuerfel \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox