* [PATCH] ata: dwc: add DMADEVICES dependency
@ 2016-05-11 12:44 Arnd Bergmann
2016-05-11 12:57 ` Måns Rullgård
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-05-11 12:44 UTC (permalink / raw)
To: Tejun Heo
Cc: Arnd Bergmann, Mans Rullgard, Andy Shevchenko, linux-ide,
linux-kernel
The dwc_460ex SATA driver has become available on non-powerpc architectures
and may cause randconfig build errors when CONFIG_DMADEVICES is not set:
warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
This adds an explcit Kconfig dependency so we can only build
configurations that build without warnings.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 41b0725e58ad..8f7a4a4d2566 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -322,7 +322,7 @@ config SATA_DWC
config SATA_DWC_OLD_DMA
bool "Support old device trees"
- depends on SATA_DWC
+ depends on SATA_DWC && DMADEVICES
select DW_DMAC_CORE
default y if 460EX
help
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ata: dwc: add DMADEVICES dependency
2016-05-11 12:44 [PATCH] ata: dwc: add DMADEVICES dependency Arnd Bergmann
@ 2016-05-11 12:57 ` Måns Rullgård
2016-05-11 13:13 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Måns Rullgård @ 2016-05-11 12:57 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Tejun Heo, Andy Shevchenko, linux-ide, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The dwc_460ex SATA driver has become available on non-powerpc architectures
> and may cause randconfig build errors when CONFIG_DMADEVICES is not set:
>
> warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
> ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
> ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
>
> This adds an explcit Kconfig dependency so we can only build
> configurations that build without warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 41b0725e58ad..8f7a4a4d2566 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -322,7 +322,7 @@ config SATA_DWC
>
> config SATA_DWC_OLD_DMA
> bool "Support old device trees"
> - depends on SATA_DWC
> + depends on SATA_DWC && DMADEVICES
> select DW_DMAC_CORE
> default y if 460EX
> help
> --
Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES?
--
Måns Rullgård
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ata: dwc: add DMADEVICES dependency
2016-05-11 12:57 ` Måns Rullgård
@ 2016-05-11 13:13 ` Arnd Bergmann
2016-05-11 13:19 ` Måns Rullgård
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-05-11 13:13 UTC (permalink / raw)
To: Måns Rullgård
Cc: Tejun Heo, Andy Shevchenko, linux-ide, linux-kernel
On Wednesday 11 May 2016 13:57:08 Måns Rullgård wrote:
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index 41b0725e58ad..8f7a4a4d2566 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -322,7 +322,7 @@ config SATA_DWC
> >
> > config SATA_DWC_OLD_DMA
> > bool "Support old device trees"
> > - depends on SATA_DWC
> > + depends on SATA_DWC && DMADEVICES
> > select DW_DMAC_CORE
> > default y if 460EX
> > help
> > --
>
> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES?
No, all dmaengine drivers depend on DMADEVICES, so that would
cause a circular dependency.
The normal behavior for DMA slave drivers is to use the generic
DMA API and have a dependency on DMADEVICES but not on a particular
DMA engine implementation. In this case, the driver uses an exported
interface of the dw_dma driver directly, so we also need to select
that one, but it doesn't mean we can skip the normal dependency.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata: dwc: add DMADEVICES dependency
2016-05-11 13:13 ` Arnd Bergmann
@ 2016-05-11 13:19 ` Måns Rullgård
2016-05-11 13:32 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Måns Rullgård @ 2016-05-11 13:19 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Tejun Heo, Andy Shevchenko, linux-ide, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> On Wednesday 11 May 2016 13:57:08 Måns Rullgård wrote:
>> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> > index 41b0725e58ad..8f7a4a4d2566 100644
>> > --- a/drivers/ata/Kconfig
>> > +++ b/drivers/ata/Kconfig
>> > @@ -322,7 +322,7 @@ config SATA_DWC
>> >
>> > config SATA_DWC_OLD_DMA
>> > bool "Support old device trees"
>> > - depends on SATA_DWC
>> > + depends on SATA_DWC && DMADEVICES
>> > select DW_DMAC_CORE
>> > default y if 460EX
>> > help
>> > --
>>
>> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES?
>
> No, all dmaengine drivers depend on DMADEVICES, so that would
> cause a circular dependency.
>
> The normal behavior for DMA slave drivers is to use the generic
> DMA API and have a dependency on DMADEVICES but not on a particular
> DMA engine implementation. In this case, the driver uses an exported
> interface of the dw_dma driver directly, so we also need to select
> that one, but it doesn't mean we can skip the normal dependency.
OK, but then shouldn't the main SATA_DWC have this dependency since it
uses the DMA API?
--
Måns Rullgård
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata: dwc: add DMADEVICES dependency
2016-05-11 13:19 ` Måns Rullgård
@ 2016-05-11 13:32 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-05-11 13:32 UTC (permalink / raw)
To: Måns Rullgård
Cc: Tejun Heo, Andy Shevchenko, linux-ide, linux-kernel
On Wednesday 11 May 2016 14:19:05 Måns Rullgård wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > On Wednesday 11 May 2016 13:57:08 Måns Rullgård wrote:
> >> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> >> > index 41b0725e58ad..8f7a4a4d2566 100644
> >> > --- a/drivers/ata/Kconfig
> >> > +++ b/drivers/ata/Kconfig
> >> > @@ -322,7 +322,7 @@ config SATA_DWC
> >> >
> >> > config SATA_DWC_OLD_DMA
> >> > bool "Support old device trees"
> >> > - depends on SATA_DWC
> >> > + depends on SATA_DWC && DMADEVICES
> >> > select DW_DMAC_CORE
> >> > default y if 460EX
> >> > help
> >> > --
> >>
> >> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES?
> >
> > No, all dmaengine drivers depend on DMADEVICES, so that would
> > cause a circular dependency.
> >
> > The normal behavior for DMA slave drivers is to use the generic
> > DMA API and have a dependency on DMADEVICES but not on a particular
> > DMA engine implementation. In this case, the driver uses an exported
> > interface of the dw_dma driver directly, so we also need to select
> > that one, but it doesn't mean we can skip the normal dependency.
>
> OK, but then shouldn't the main SATA_DWC have this dependency since it
> uses the DMA API?
>
Right, I missed that and thought only the SATA_DWC_OLD_DMA variant
used dmaengine at all. I'll send a new version of my patch then.
Thanks,
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-11 13:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-11 12:44 [PATCH] ata: dwc: add DMADEVICES dependency Arnd Bergmann
2016-05-11 12:57 ` Måns Rullgård
2016-05-11 13:13 ` Arnd Bergmann
2016-05-11 13:19 ` Måns Rullgård
2016-05-11 13:32 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox