* Re: sata & scsi suggestion for make menuconfig
[not found] ` <20070907230529.GX16806@vanheusden.com>
@ 2007-09-08 7:05 ` Stefan Richter
2007-09-08 7:29 ` Jan Engelhardt
2007-09-08 16:31 ` Randy Dunlap
0 siblings, 2 replies; 7+ messages in thread
From: Stefan Richter @ 2007-09-08 7:05 UTC (permalink / raw)
To: Folkert van Heusden; +Cc: Randy Dunlap, linux-kernel, linux-ide
(added Cc linux-ide)
Folkert van Heusden wrote:
>>>> A popup makes some sense, but I don't know if menuconfig knows how to
>>>> do popup warnings... and it needs to be done for all *configs,
>>>> not just menuconfig.
>>> Maybe add a new type?
>> How about
>> comment "Note: 'SCSI disk support' is required for SATA/PATA HDDs!"
>> depends on ATA && !BLK_DEV_SD
>
> Yes! Maybe create some status-line at the bottom of the screen in which
> these hints scrollby. Like powertop does.
'comment' is already supported by make {menu,x,g}config and AFAIK by
make oldconfig too. It is not effective in make oldconfig though
because it will scroll off the screen quickly.
I am not a friend of 'select', but maybe the following actually helps.
I didn't follow all of this and previous related discussions, so I guess
somebody else suggested something like this before:
# drivers/ata/Kconfig
config ATA
[...]
comment "Controller drivers"
[...low-level drivers go here...]
comment "Storage device drivers"
config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)"
depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is
also necessary for parallel ATA (IDE) HDDs if you use the
experimental parallel ATA option.
You can say Y or M here to select SCSI disk support, or you
can do so in the 'SCSI device support' section.
[...ditto for CD/DVD-ROMs, tapes, and generic support...]
--
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sata & scsi suggestion for make menuconfig
2007-09-08 7:05 ` sata & scsi suggestion for make menuconfig Stefan Richter
@ 2007-09-08 7:29 ` Jan Engelhardt
2007-09-08 7:56 ` Stefan Richter
2007-09-08 16:31 ` Randy Dunlap
1 sibling, 1 reply; 7+ messages in thread
From: Jan Engelhardt @ 2007-09-08 7:29 UTC (permalink / raw)
To: Stefan Richter; +Cc: Folkert van Heusden, Randy Dunlap, linux-kernel, linux-ide
On Sep 8 2007 09:05, Stefan Richter wrote:
>config ATA
> [...]
>
>comment "Controller drivers"
>
>[...low-level drivers go here...]
>
>comment "Storage device drivers"
>
>config ATA_SD
> tristate "SATA/PATA HDD support (via SCSI disk support)"
> depends on ATA
> select BLK_DEV_SD
> help
> 'SCSI disk support' is required to access SATA HDDs. It is
> also necessary for parallel ATA (IDE) HDDs if you use the
> experimental parallel ATA option.
>
> You can say Y or M here to select SCSI disk support, or you
> can do so in the 'SCSI device support' section.
>
>[...ditto for CD/DVD-ROMs, tapes, and generic support...]
And what uses ATA_SD, or is the user supposed to manually enable it?
Jan
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sata & scsi suggestion for make menuconfig
2007-09-08 7:29 ` Jan Engelhardt
@ 2007-09-08 7:56 ` Stefan Richter
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Richter @ 2007-09-08 7:56 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Folkert van Heusden, Randy Dunlap, linux-kernel, linux-ide
Jan Engelhardt wrote:
> On Sep 8 2007 09:05, Stefan Richter wrote:
>> config ATA_SD
>> tristate "SATA/PATA HDD support (via SCSI disk support)"
>> depends on ATA
>> select BLK_DEV_SD
>> help
>> 'SCSI disk support' is required to access SATA HDDs. It is
[...]
>> You can say Y or M here to select SCSI disk support, or you
>> can do so in the 'SCSI device support' section.
[...]
> And what uses ATA_SD, or is the user supposed to manually enable it?
It is merely there to produce the prompt which people asked for.
CONFIG_ATA_SD (or CONFIG_ATA_BLK_DEV_SD or whatever) won't turn up in
any Makefile or source code.
Note, I'm not fond of 'select' nor of dummy Kconfig variables. Plus I
can personally live very well with the current solution (sd_mod et al
are mentioned in the help text at CONFIG_ATA). That's why I posted only
the example instead of a complete patch.
--
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sata & scsi suggestion for make menuconfig
2007-09-08 7:05 ` sata & scsi suggestion for make menuconfig Stefan Richter
2007-09-08 7:29 ` Jan Engelhardt
@ 2007-09-08 16:31 ` Randy Dunlap
2007-09-08 16:44 ` Stefan Richter
1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2007-09-08 16:31 UTC (permalink / raw)
To: Stefan Richter; +Cc: Folkert van Heusden, linux-kernel, linux-ide
Stefan Richter wrote:
> (added Cc linux-ide)
>
> Folkert van Heusden wrote:
>>>>> A popup makes some sense, but I don't know if menuconfig knows how to
>>>>> do popup warnings... and it needs to be done for all *configs,
>>>>> not just menuconfig.
>>>> Maybe add a new type?
>>> How about
>>> comment "Note: 'SCSI disk support' is required for SATA/PATA HDDs!"
>>> depends on ATA && !BLK_DEV_SD
>> Yes! Maybe create some status-line at the bottom of the screen in which
>> these hints scrollby. Like powertop does.
>
> 'comment' is already supported by make {menu,x,g}config and AFAIK by
> make oldconfig too. It is not effective in make oldconfig though
> because it will scroll off the screen quickly.
>
> I am not a friend of 'select', but maybe the following actually helps.
> I didn't follow all of this and previous related discussions, so I guess
> somebody else suggested something like this before:
>
The problem with 'select' here is that it will enable BLK_DEV_SD,
but if SCSI is not enabled, it will not become enabled -- i.e.,
select does not follow the dependency chain. So usually the
kernel will not build unless SCSI is enabled by the user.
> # drivers/ata/Kconfig
>
> config ATA
> [...]
>
> comment "Controller drivers"
>
> [...low-level drivers go here...]
>
> comment "Storage device drivers"
>
> config ATA_SD
> tristate "SATA/PATA HDD support (via SCSI disk support)"
> depends on ATA
> select BLK_DEV_SD
> help
> 'SCSI disk support' is required to access SATA HDDs. It is
> also necessary for parallel ATA (IDE) HDDs if you use the
> experimental parallel ATA option.
>
> You can say Y or M here to select SCSI disk support, or you
> can do so in the 'SCSI device support' section.
>
> [...ditto for CD/DVD-ROMs, tapes, and generic support...]
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sata & scsi suggestion for make menuconfig
2007-09-08 16:31 ` Randy Dunlap
@ 2007-09-08 16:44 ` Stefan Richter
2007-09-08 16:48 ` Randy Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Richter @ 2007-09-08 16:44 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Folkert van Heusden, linux-kernel, linux-ide
Randy Dunlap wrote:
> Stefan Richter wrote:
>> I am not a friend of 'select', but maybe the following actually helps.
...
> The problem with 'select' here is that it will enable BLK_DEV_SD,
> but if SCSI is not enabled, it will not become enabled -- i.e.,
> select does not follow the dependency chain. So usually the
> kernel will not build unless SCSI is enabled by the user.
...
>> config ATA_SD
>> tristate "SATA/PATA HDD support (via SCSI disk support)"
>> depends on ATA
>> select BLK_DEV_SD
>> help
>> 'SCSI disk support' is required to access SATA HDDs. It is
...
I checked the dependencies. ATA depends on SCSI (actually, selects
SCSI), so all is well. Otherwise I would have added more dependencies
to ATA_SD.
--
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sata & scsi suggestion for make menuconfig
2007-09-08 16:44 ` Stefan Richter
@ 2007-09-08 16:48 ` Randy Dunlap
2007-09-08 19:45 ` Stefan Richter
0 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2007-09-08 16:48 UTC (permalink / raw)
To: Stefan Richter; +Cc: Folkert van Heusden, linux-kernel, linux-ide
On Sat, 08 Sep 2007 18:44:46 +0200 Stefan Richter wrote:
> Randy Dunlap wrote:
> > Stefan Richter wrote:
> >> I am not a friend of 'select', but maybe the following actually helps.
> ...
> > The problem with 'select' here is that it will enable BLK_DEV_SD,
> > but if SCSI is not enabled, it will not become enabled -- i.e.,
> > select does not follow the dependency chain. So usually the
> > kernel will not build unless SCSI is enabled by the user.
> ...
> >> config ATA_SD
> >> tristate "SATA/PATA HDD support (via SCSI disk support)"
> >> depends on ATA
> >> select BLK_DEV_SD
> >> help
> >> 'SCSI disk support' is required to access SATA HDDs. It is
> ...
>
> I checked the dependencies. ATA depends on SCSI (actually, selects
> SCSI), so all is well. Otherwise I would have added more dependencies
> to ATA_SD.
Ah, that's good, then. Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sata & scsi suggestion for make menuconfig
2007-09-08 16:48 ` Randy Dunlap
@ 2007-09-08 19:45 ` Stefan Richter
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Richter @ 2007-09-08 19:45 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Folkert van Heusden, linux-kernel, linux-ide
Randy Dunlap wrote:
> On Sat, 08 Sep 2007 18:44:46 +0200 Stefan Richter wrote:
>> Randy Dunlap wrote:
>>> The problem with 'select' here is that it will enable BLK_DEV_SD,
>>> but if SCSI is not enabled, it will not become enabled -- i.e.,
>>> select does not follow the dependency chain. So usually the
>>> kernel will not build unless SCSI is enabled by the user.
...
>> I checked the dependencies. ATA depends on SCSI (actually, selects
>> SCSI), so all is well. Otherwise I would have added more dependencies
>> to ATA_SD.
>
> Ah, that's good, then.
Not completely though. Whenever a 'select' is inserted into the
dependency graph, the whole thing becomes more fragile WRT future changes.
--
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-09-08 19:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070907124800.GP16806@vanheusden.com>
[not found] ` <20070907083522.3191a4ba.randy.dunlap@oracle.com>
[not found] ` <20070907155903.GR16806@vanheusden.com>
[not found] ` <46E17A81.7020304@s5r6.in-berlin.de>
[not found] ` <20070907230529.GX16806@vanheusden.com>
2007-09-08 7:05 ` sata & scsi suggestion for make menuconfig Stefan Richter
2007-09-08 7:29 ` Jan Engelhardt
2007-09-08 7:56 ` Stefan Richter
2007-09-08 16:31 ` Randy Dunlap
2007-09-08 16:44 ` Stefan Richter
2007-09-08 16:48 ` Randy Dunlap
2007-09-08 19:45 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox