Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-ide@vger.kernel.org,
	davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] IDE: palm_bk3710: convert clock usage after clkdev conversion
Date: Mon, 13 Jul 2009 22:21:29 +0400	[thread overview]
Message-ID: <4A5B7B29.7070400@ru.mvista.com> (raw)
In-Reply-To: <1246919176-28683-1-git-send-email-khilman@deeprootsystems.com>

Hello.

Kevin Hilman wrote:

> DaVinci core code has converted to the new clkdev API so
> clock name strings are not needed.  Instead, just the a
> 'struct device' pointer is needed.
> 
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> ---
> Fix needed for 2.6.31
> 
>  drivers/ide/palm_bk3710.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
> index 3c1dc01..f8eddf0 100644
> --- a/drivers/ide/palm_bk3710.c
> +++ b/drivers/ide/palm_bk3710.c
> @@ -318,7 +318,7 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
>  	int i, rc;
>  	struct ide_hw hw, *hws[] = { &hw };
>  
> -	clk = clk_get(&pdev->dev, "IDECLK");
> +	clk = clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(clk))
>  		return -ENODEV;
>  

    It doesn't seem strictly necessary for 2.6.31 -- only in the sense that 
"IDECLK" isn't named so anymore, however, clk_get() should still work.

MBR, Sergei

  reply	other threads:[~2009-07-13 18:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 22:26 [PATCH] IDE: palm_bk3710: convert clock usage after clkdev conversion Kevin Hilman
2009-07-13 18:21 ` Sergei Shtylyov [this message]
2009-07-13 21:01   ` Kevin Hilman
2009-07-13 21:07     ` David Miller
2009-07-14 23:23       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5B7B29.7070400@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox