From: Kevin Hilman <khilman@deeprootsystems.com>
To: David Miller <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org, sshtylyov@ru.mvista.com
Subject: Re: [PATCH] IDE: palm_bk3710: convert clock usage after clkdev conversion
Date: Tue, 14 Jul 2009 16:23:53 -0700 [thread overview]
Message-ID: <636c5030907141623p7b884a44q3ff95fde0897f8dc@mail.gmail.com> (raw)
In-Reply-To: <20090713.140705.140939312.davem@davemloft.net>
On Mon, Jul 13, 2009 at 2:07 PM, David Miller<davem@davemloft.net> wrote:
> From: Kevin Hilman <khilman@deeprootsystems.com>
> Date: Mon, 13 Jul 2009 14:01:55 -0700
>
>> Sergei Shtylyov <sshtylyov@ru.mvista.com> writes:
>>
>>> Hello.
>>>
>>> Kevin Hilman wrote:
>>>
>>>> DaVinci core code has converted to the new clkdev API so
>>>> clock name strings are not needed. Instead, just the a
>>>> 'struct device' pointer is needed.
>>>>
>>>> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>>>
>>> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>>>
>>>> ---
>>>> Fix needed for 2.6.31
>>
>> Can this fix be merged for the .31-rc series please?
>>
>>> It doesn't seem strictly necessary for 2.6.31 -- only in the sense
>>> that "IDECLK" isn't named so anymore, however, clk_get() should still
>>> work.
>
> Either it's needed or it isn't. It seems like it isn't, and since
> the rules for integrating changes in the RC series right now is
> strict, I'm only going to merge something if it is actually
> necessary.
>
OK, after looking closer at clkdev, it looks like things will continue
to work in .31 without this patch, so this is merely confusing, and
not broken.
I'm ok if it waits until next merge window.
Thanks,
Kevin
prev parent reply other threads:[~2009-07-14 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 22:26 [PATCH] IDE: palm_bk3710: convert clock usage after clkdev conversion Kevin Hilman
2009-07-13 18:21 ` Sergei Shtylyov
2009-07-13 21:01 ` Kevin Hilman
2009-07-13 21:07 ` David Miller
2009-07-14 23:23 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636c5030907141623p7b884a44q3ff95fde0897f8dc@mail.gmail.com \
--to=khilman@deeprootsystems.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox