From: Tejun Heo <tj@kernel.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: Sparse warning in sata_nv.c
Date: Wed, 20 Jan 2010 12:15:35 +0900 [thread overview]
Message-ID: <4B567557.1070607@kernel.org> (raw)
In-Reply-To: <20100106105416.4bdc225a@nehalam>
On 01/07/2010 03:54 AM, Stephen Hemminger wrote:
> Sparse complains about the following, not sure best way to fix it.
> Either change ATA_NCQ_SHT() or do manual expansion.
Hmm... that's an intended abuse of duplicate initializers. The macro
provides stock values and each driver overrides fields as necessary
with duplicate initializers which come below the macro. It would be
great if there's a way to tell sparse that an initializer may be
overridden.
Thanks.
--
tejun
prev parent reply other threads:[~2010-01-20 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 18:54 Sparse warning in sata_nv.c Stephen Hemminger
2010-01-20 3:15 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B567557.1070607@kernel.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox