* Sparse warning in sata_nv.c
@ 2010-01-06 18:54 Stephen Hemminger
2010-01-20 3:15 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-01-06 18:54 UTC (permalink / raw)
To: linux-ide
Sparse complains about the following, not sure best way to fix it.
Either change ATA_NCQ_SHT() or do manual expansion.
--
CHECK drivers/ata/sata_nv.c
drivers/ata/sata_nv.c:394:9: warning: Initializer entry defined twice
drivers/ata/sata_nv.c:398:10: also defined here
drivers/ata/sata_nv.c:402:9: warning: Initializer entry defined twice
drivers/ata/sata_nv.c:406:10: also defined here
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Sparse warning in sata_nv.c
2010-01-06 18:54 Sparse warning in sata_nv.c Stephen Hemminger
@ 2010-01-20 3:15 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2010-01-20 3:15 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: linux-ide
On 01/07/2010 03:54 AM, Stephen Hemminger wrote:
> Sparse complains about the following, not sure best way to fix it.
> Either change ATA_NCQ_SHT() or do manual expansion.
Hmm... that's an intended abuse of duplicate initializers. The macro
provides stock values and each driver overrides fields as necessary
with duplicate initializers which come below the macro. It would be
great if there's a way to tell sparse that an initializer may be
overridden.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-20 3:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-06 18:54 Sparse warning in sata_nv.c Stephen Hemminger
2010-01-20 3:15 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox