* [PATCH] IDE: ide-floppy, remove unnecessary NULL check
[not found] <1289034412-24278-1-git-send-email-jslaby@suse.cz>
@ 2010-11-06 9:06 ` Jiri Slaby
2010-11-06 12:00 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiri Slaby @ 2010-11-06 9:06 UTC (permalink / raw)
To: jirislaby; +Cc: linux-kernel, Christoph Hellwig, David S. Miller, linux-ide
Stanse founf that rq in ide_floppy_callback cannot be NULL, because it
is dereferenced all around. So remove the superfluous check.
This appeared after blk_* macors removal.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
---
drivers/ide/ide-floppy.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 5406b6e..536ff68 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -73,7 +73,7 @@ static int ide_floppy_callback(ide_drive_t *drive, int dsc)
drive->failed_pc = NULL;
if (pc->c[0] == GPCMD_READ_10 || pc->c[0] == GPCMD_WRITE_10 ||
- (rq && rq->cmd_type == REQ_TYPE_BLOCK_PC))
+ rq->cmd_type == REQ_TYPE_BLOCK_PC)
uptodate = 1; /* FIXME */
else if (pc->c[0] == GPCMD_REQUEST_SENSE) {
--
1.7.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IDE: ide-floppy, remove unnecessary NULL check
2010-11-06 9:06 ` [PATCH] IDE: ide-floppy, remove unnecessary NULL check Jiri Slaby
@ 2010-11-06 12:00 ` Sergei Shtylyov
2010-11-06 12:10 ` Borislav Petkov
2010-11-22 19:39 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2010-11-06 12:00 UTC (permalink / raw)
To: Jiri Slaby
Cc: jirislaby, linux-kernel, Christoph Hellwig, David S. Miller,
linux-ide
Hello.
On 06-11-2010 12:06, Jiri Slaby wrote:
> Stanse founf that rq in ide_floppy_callback cannot be NULL, because it
found?
> is dereferenced all around. So remove the superfluous check.
> This appeared after blk_* macors removal.
macros?
> Signed-off-by: Jiri Slaby<jslaby@suse.cz>
> Cc: Christoph Hellwig<hch@lst.de>
> Cc: "David S. Miller"<davem@davemloft.net>
> Cc: linux-ide@vger.kernel.org
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IDE: ide-floppy, remove unnecessary NULL check
2010-11-06 9:06 ` [PATCH] IDE: ide-floppy, remove unnecessary NULL check Jiri Slaby
2010-11-06 12:00 ` Sergei Shtylyov
@ 2010-11-06 12:10 ` Borislav Petkov
2010-11-22 19:39 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2010-11-06 12:10 UTC (permalink / raw)
To: Jiri Slaby
Cc: jirislaby, linux-kernel, Christoph Hellwig, David S. Miller,
linux-ide
On Sat, Nov 06, 2010 at 10:06:51AM +0100, Jiri Slaby wrote:
> Stanse founf that rq in ide_floppy_callback cannot be NULL, because it
> is dereferenced all around. So remove the superfluous check.
>
> This appeared after blk_* macors removal.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-ide@vger.kernel.org
> ---
> drivers/ide/ide-floppy.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
> index 5406b6e..536ff68 100644
> --- a/drivers/ide/ide-floppy.c
> +++ b/drivers/ide/ide-floppy.c
> @@ -73,7 +73,7 @@ static int ide_floppy_callback(ide_drive_t *drive, int dsc)
> drive->failed_pc = NULL;
>
> if (pc->c[0] == GPCMD_READ_10 || pc->c[0] == GPCMD_WRITE_10 ||
> - (rq && rq->cmd_type == REQ_TYPE_BLOCK_PC))
> + rq->cmd_type == REQ_TYPE_BLOCK_PC)
> uptodate = 1; /* FIXME */
> else if (pc->c[0] == GPCMD_REQUEST_SENSE) {
If this isn't a fix for a real bug, then there's no need for it since
IDE is deprecated and thus in bugfix mode only.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IDE: ide-floppy, remove unnecessary NULL check
2010-11-06 9:06 ` [PATCH] IDE: ide-floppy, remove unnecessary NULL check Jiri Slaby
2010-11-06 12:00 ` Sergei Shtylyov
2010-11-06 12:10 ` Borislav Petkov
@ 2010-11-22 19:39 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-11-22 19:39 UTC (permalink / raw)
To: jslaby; +Cc: jirislaby, linux-kernel, hch, linux-ide
From: Jiri Slaby <jslaby@suse.cz>
Date: Sat, 6 Nov 2010 10:06:51 +0100
> Stanse founf that rq in ide_floppy_callback cannot be NULL, because it
> is dereferenced all around. So remove the superfluous check.
>
> This appeared after blk_* macors removal.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Applied with commit message typos fixed.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-22 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1289034412-24278-1-git-send-email-jslaby@suse.cz>
2010-11-06 9:06 ` [PATCH] IDE: ide-floppy, remove unnecessary NULL check Jiri Slaby
2010-11-06 12:00 ` Sergei Shtylyov
2010-11-06 12:10 ` Borislav Petkov
2010-11-22 19:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox