From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v2] pata_hpt37x: coding style cleanup
Date: Sat, 08 Jan 2011 15:30:29 -0500 [thread overview]
Message-ID: <4D28C965.8070008@pobox.com> (raw)
In-Reply-To: <201101081901.37479.sshtylyov@ru.mvista.com>
On 01/08/2011 11:01 AM, Sergei Shtylyov wrote:
> Changes from the previous version:
> - fixed several cases of a line over 80 chars that checkpatch.pl didn't report.
And for pata_hpt366 you also wrote:
> Changes from the previous version:
> - fixed one case of a line over 80 chars that checkpatch.pl didn't report.
These will need to be on top of your patches applied last night (and
just sent to Linus).
FWIW, it is ok to combine such changes into a single patch. You don't
have to separate our pata_hpt37x and pata_hpt366 coding style cleanups.
The main goal with separate patches is separating classes of changes,
so that human reviewers and 'git bisect' may notice breakage at a
useful, fine-grained level. Separating patches at the driver boundary
is less useful from that perspective (though permissible, if that is
your preferred method of working).
Jeff
next prev parent reply other threads:[~2011-01-08 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-08 16:01 [PATCH v2] pata_hpt37x: coding style cleanup Sergei Shtylyov
2011-01-08 20:30 ` Jeff Garzik [this message]
2011-01-10 15:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D28C965.8070008@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox