Re: [PATCH v2] pata_hpt37x: coding style cleanup

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Jeff Garzik wrote:

>> Changes from the previous version:
>> - fixed several cases of a line over 80 chars that checkpatch.pl 
>> didn't report.

> And for pata_hpt366 you also wrote:

>> Changes from the previous version:
>> - fixed one case of a line over 80 chars that checkpatch.pl didn't 
>> report.

    Looks like checkpatch.pl now doesn't report the lines with printk() messages 
as being too long, thanks to the previous discussions on the topic. Though those 
could be made shorter without breaking the messages in this case anyway...

> These will need to be on top of your patches applied last night (and 
> just sent to Linus).

   I think I will join these changes to the 2 patches that I've generated on 
Saturday. Looks like the idea of creating v2 of the coding style clean-up 
patches wasn't really good as those extra long lines would have been truncated 
by that 2-patch series anyway...

> FWIW, it is ok to combine such changes into a single patch.  You don't 
> have to separate our pata_hpt37x and pata_hpt366 coding style cleanups. 
>  The main goal with separate patches is separating classes of changes, 
> so that human reviewers and 'git bisect' may notice breakage at a 
> useful, fine-grained level.  Separating patches at the driver boundary 
> is less useful from that perspective (though permissible, if that is 
> your preferred method of working).

    I've preferred to give the exact error/warning statistics and the list of 
changes for each driver in this case.

>     Jeff

WBR, Sergei