From: Mark Lord <kernel@teksavvy.com>
To: Tero Roponen <tero.roponen@gmail.com>
Cc: linux-ide@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Jeff Garzik <jgarzik@redhat.com>
Subject: Re: libata: init ata_print_id to 0
Date: Mon, 23 Apr 2012 11:32:57 -0400 [thread overview]
Message-ID: <4F957629.1050102@teksavvy.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1204221136450.1947@terrop>
On 12-04-22 04:38 AM, Tero Roponen wrote:
..
> The change of numbering comes from commit 85d6725b7c0d7e3f ("libata:
> make ata_print_id atomic") that changed lines like
>
> ap->print_id = ata_print_id++;
> to
> ap->print_id = atomic_inc_return(&ata_print_id);
>
> As the latter behaves like ++ata_print_id, we must initialize
> it to zero to start the numbering from one.
Darn! And here I though we'd finally end up with libata numbering
matching the scsi host numbering (on most systems). :)
next prev parent reply other threads:[~2012-04-23 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 8:38 libata: init ata_print_id to 0 Tero Roponen
2012-04-22 14:57 ` Dan Williams
2012-04-23 15:32 ` Mark Lord [this message]
2012-04-23 16:34 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F957629.1050102@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=dan.j.williams@intel.com \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=tero.roponen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox