* [PATCH #upstream] libata: export local port number through /sys
@ 2013-01-24 17:52 David Milburn
2013-02-25 21:04 ` David Milburn
0 siblings, 1 reply; 7+ messages in thread
From: David Milburn @ 2013-01-24 17:52 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, kay.sievers, coughlan, fengguang.wu, gwendal
Export <global port>.<local port> format through /sys
./pci0000:00/0000:00:1f.2/ata1.1
./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
./pci0000:00/0000:00:1f.2/ata1.1/ata_port
./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
./pci0000:00/0000:00:1f.2/ata2.2
./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
./pci0000:00/0000:00:1f.2/ata2.2/ata_port
./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
./pci0000:00/0000:00:1f.2/ata3.3
./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
./pci0000:00/0000:00:1f.2/ata3.3/ata_port
./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
./pci0000:00/0000:00:1f.2/ata4.4
./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
./pci0000:00/0000:00:1f.2/ata4.4/ata_port
./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
./pci0000:00/0000:00:1f.2/ata5.5
./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
./pci0000:00/0000:00:1f.2/ata5.5/ata_port
./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
./pci0000:00/0000:00:1f.2/ata6.6
./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
./pci0000:00/0000:00:1f.2/ata6.6/ata_port
./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
(2nd controller with port multiplier)
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.10/dev7.1.10.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.10/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.11/dev7.1.11.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.11/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.12/dev7.1.12.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.12/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.13/dev7.1.13.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.13/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.14/dev7.1.14.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.14/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1/dev7.1.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.0/dev7.1.0.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.0/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.1/dev7.1.1.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.1/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.2/dev7.1.2.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.2/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.3/dev7.1.3.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.3/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.4/dev7.1.4.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.4/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.5/dev7.1.5.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.5/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.6/dev7.1.6.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.6/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.7/dev7.1.7.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.7/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.8/dev7.1.8.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.8/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.9/dev7.1.9.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.9/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/ata_port
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/ata_port/ata7.1
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/link8.2/dev8.2.0/ata_device
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/link8.2/ata_link
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/ata_port
./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/ata_port/ata8.2
Signed-off-by: David Milburn <dmilburn@redhat.com>
---
This could be modified to fit on top of "Insert ATA transport objects in SCSI
sysfs topology".
drivers/ata/libata-core.c | 6 ++++--
drivers/ata/libata-transport.c | 10 +++++-----
include/linux/libata.h | 1 +
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4b6fb48..a796482 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5629,6 +5629,7 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
ap->pflags |= ATA_PFLAG_INITIALIZING | ATA_PFLAG_FROZEN;
ap->lock = &host->lock;
ap->print_id = -1;
+ ap->local_print_id = -1;
ap->host = host;
ap->dev = host->dev;
@@ -6119,9 +6120,10 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
kfree(host->ports[i]);
/* give ports names and add SCSI hosts */
- for (i = 0; i < host->n_ports; i++)
+ for (i = 0; i < host->n_ports; i++) {
host->ports[i]->print_id = atomic_inc_return(&ata_print_id);
-
+ host->ports[i]->local_print_id = i + 1;
+ }
/* Create associated sysfs transport objects */
for (i = 0; i < host->n_ports; i++) {
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
index c04d393..176bed8 100644
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -284,7 +284,7 @@ int ata_tport_add(struct device *parent,
dev->parent = get_device(parent);
dev->release = ata_tport_release;
- dev_set_name(dev, "ata%d", ap->print_id);
+ dev_set_name(dev, "ata%d.%d", ap->print_id, ap->local_print_id);
transport_setup_device(dev);
error = device_add(dev);
if (error) {
@@ -410,9 +410,9 @@ int ata_tlink_add(struct ata_link *link)
dev->parent = get_device(&ap->tdev);
dev->release = ata_tlink_release;
if (ata_is_host_link(link))
- dev_set_name(dev, "link%d", ap->print_id);
+ dev_set_name(dev, "link%d.%d", ap->print_id, ap->local_print_id);
else
- dev_set_name(dev, "link%d.%d", ap->print_id, link->pmp);
+ dev_set_name(dev, "link%d.%d.%d", ap->print_id, ap->local_print_id, link->pmp);
transport_setup_device(dev);
@@ -638,9 +638,9 @@ static int ata_tdev_add(struct ata_device *ata_dev)
dev->parent = get_device(&link->tdev);
dev->release = ata_tdev_release;
if (ata_is_host_link(link))
- dev_set_name(dev, "dev%d.%d", ap->print_id,ata_dev->devno);
+ dev_set_name(dev, "dev%d.%d.%d", ap->print_id, ap->local_print_id, ata_dev->devno);
else
- dev_set_name(dev, "dev%d.%d.0", ap->print_id, link->pmp);
+ dev_set_name(dev, "dev%d.%d.%d.0", ap->print_id, ap->local_print_id, link->pmp);
transport_setup_device(dev);
error = device_add(dev);
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 91c9d10..62d5c1a 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -745,6 +745,7 @@ struct ata_port {
/* Flags that change dynamically, protected by ap->lock */
unsigned int pflags; /* ATA_PFLAG_xxx */
unsigned int print_id; /* user visible unique port ID */
+ unsigned int local_print_id; /* host local port ID */
unsigned int port_no; /* 0 based port no. inside the host */
#ifdef CONFIG_ATA_SFF
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH #upstream] libata: export local port number through /sys
2013-01-24 17:52 [PATCH #upstream] libata: export local port number through /sys David Milburn
@ 2013-02-25 21:04 ` David Milburn
2013-02-25 21:16 ` Jeff Garzik
2013-02-26 15:26 ` Kay Sievers
0 siblings, 2 replies; 7+ messages in thread
From: David Milburn @ 2013-02-25 21:04 UTC (permalink / raw)
To: jgarzik
Cc: David Milburn, linux-ide, kay.sievers, coughlan, fengguang.wu,
gwendal
David Milburn wrote:
> Export <global port>.<local port> format through /sys
>
> ./pci0000:00/0000:00:1f.2/ata1.1
> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port
> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
> ./pci0000:00/0000:00:1f.2/ata2.2
> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port
> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
> ./pci0000:00/0000:00:1f.2/ata3.3
> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port
> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
> ./pci0000:00/0000:00:1f.2/ata4.4
> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port
> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
> ./pci0000:00/0000:00:1f.2/ata5.5
> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port
> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
> ./pci0000:00/0000:00:1f.2/ata6.6
> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port
> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
>
> (2nd controller with port multiplier)
>
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.10/dev7.1.10.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.10/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.11/dev7.1.11.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.11/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.12/dev7.1.12.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.12/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.13/dev7.1.13.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.13/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.14/dev7.1.14.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.14/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1/dev7.1.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.0/dev7.1.0.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.0/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.1/dev7.1.1.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.1/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.2/dev7.1.2.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.2/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.3/dev7.1.3.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.3/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.4/dev7.1.4.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.4/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.5/dev7.1.5.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.5/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.6/dev7.1.6.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.6/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.7/dev7.1.7.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.7/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.8/dev7.1.8.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.8/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.9/dev7.1.9.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.9/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/ata_port
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/ata_port/ata7.1
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/link8.2/dev8.2.0/ata_device
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/link8.2/ata_link
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/ata_port
> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/ata_port/ata8.2
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> ---
> This could be modified to fit on top of "Insert ATA transport objects in SCSI
> sysfs topology".
>
> drivers/ata/libata-core.c | 6 ++++--
> drivers/ata/libata-transport.c | 10 +++++-----
> include/linux/libata.h | 1 +
> 3 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4b6fb48..a796482 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -5629,6 +5629,7 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
> ap->pflags |= ATA_PFLAG_INITIALIZING | ATA_PFLAG_FROZEN;
> ap->lock = &host->lock;
> ap->print_id = -1;
> + ap->local_print_id = -1;
> ap->host = host;
> ap->dev = host->dev;
>
> @@ -6119,9 +6120,10 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
> kfree(host->ports[i]);
>
> /* give ports names and add SCSI hosts */
> - for (i = 0; i < host->n_ports; i++)
> + for (i = 0; i < host->n_ports; i++) {
> host->ports[i]->print_id = atomic_inc_return(&ata_print_id);
> -
> + host->ports[i]->local_print_id = i + 1;
> + }
>
> /* Create associated sysfs transport objects */
> for (i = 0; i < host->n_ports; i++) {
> diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
> index c04d393..176bed8 100644
> --- a/drivers/ata/libata-transport.c
> +++ b/drivers/ata/libata-transport.c
> @@ -284,7 +284,7 @@ int ata_tport_add(struct device *parent,
>
> dev->parent = get_device(parent);
> dev->release = ata_tport_release;
> - dev_set_name(dev, "ata%d", ap->print_id);
> + dev_set_name(dev, "ata%d.%d", ap->print_id, ap->local_print_id);
> transport_setup_device(dev);
> error = device_add(dev);
> if (error) {
> @@ -410,9 +410,9 @@ int ata_tlink_add(struct ata_link *link)
> dev->parent = get_device(&ap->tdev);
> dev->release = ata_tlink_release;
> if (ata_is_host_link(link))
> - dev_set_name(dev, "link%d", ap->print_id);
> + dev_set_name(dev, "link%d.%d", ap->print_id, ap->local_print_id);
> else
> - dev_set_name(dev, "link%d.%d", ap->print_id, link->pmp);
> + dev_set_name(dev, "link%d.%d.%d", ap->print_id, ap->local_print_id, link->pmp);
>
> transport_setup_device(dev);
>
> @@ -638,9 +638,9 @@ static int ata_tdev_add(struct ata_device *ata_dev)
> dev->parent = get_device(&link->tdev);
> dev->release = ata_tdev_release;
> if (ata_is_host_link(link))
> - dev_set_name(dev, "dev%d.%d", ap->print_id,ata_dev->devno);
> + dev_set_name(dev, "dev%d.%d.%d", ap->print_id, ap->local_print_id, ata_dev->devno);
> else
> - dev_set_name(dev, "dev%d.%d.0", ap->print_id, link->pmp);
> + dev_set_name(dev, "dev%d.%d.%d.0", ap->print_id, ap->local_print_id, link->pmp);
>
> transport_setup_device(dev);
> error = device_add(dev);
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 91c9d10..62d5c1a 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -745,6 +745,7 @@ struct ata_port {
> /* Flags that change dynamically, protected by ap->lock */
> unsigned int pflags; /* ATA_PFLAG_xxx */
> unsigned int print_id; /* user visible unique port ID */
> + unsigned int local_print_id; /* host local port ID */
> unsigned int port_no; /* 0 based port no. inside the host */
>
> #ifdef CONFIG_ATA_SFF
Hi Jeff, Gwendal, Kay,
Any thoughts on this patch, is this something we could consider for
3.9?
Thanks,
David
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH #upstream] libata: export local port number through /sys
2013-02-25 21:04 ` David Milburn
@ 2013-02-25 21:16 ` Jeff Garzik
2013-02-26 15:26 ` Kay Sievers
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Garzik @ 2013-02-25 21:16 UTC (permalink / raw)
To: David Milburn; +Cc: linux-ide, kay.sievers, coughlan, fengguang.wu, gwendal
On 02/25/2013 04:04 PM, David Milburn wrote:
> Hi Jeff, Gwendal, Kay,
>
> Any thoughts on this patch, is this something we could consider for
> 3.9?
As I noted in the upstream push email (and associated git tag text), it
did not seem like all parties were happy with the sysfs layout.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH #upstream] libata: export local port number through /sys
2013-02-25 21:04 ` David Milburn
2013-02-25 21:16 ` Jeff Garzik
@ 2013-02-26 15:26 ` Kay Sievers
2013-03-05 15:48 ` Hannes Reinecke
1 sibling, 1 reply; 7+ messages in thread
From: Kay Sievers @ 2013-02-26 15:26 UTC (permalink / raw)
To: David Milburn
Cc: jgarzik, linux-ide, coughlan, fengguang.wu, gwendal,
Hannes Reinecke
On Mon, Feb 25, 2013 at 10:04 PM, David Milburn <dmilburn@redhat.com> wrote:
> David Milburn wrote:
>>
>> Export <global port>.<local port> format through /sys
>>
>> ./pci0000:00/0000:00:1f.2/ata1.1
>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port
>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
>> ./pci0000:00/0000:00:1f.2/ata2.2
>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port
>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
>> ./pci0000:00/0000:00:1f.2/ata3.3
>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port
>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
>> ./pci0000:00/0000:00:1f.2/ata4.4
>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port
>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
>> ./pci0000:00/0000:00:1f.2/ata5.5
>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port
>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
>> ./pci0000:00/0000:00:1f.2/ata6.6
>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port
>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
>>
>> (2nd controller with port multiplier)
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.10/dev7.1.10.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.10/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.11/dev7.1.11.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.11/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.12/dev7.1.12.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.12/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.13/dev7.1.13.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.13/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.14/dev7.1.14.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.14/ata_link
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1/dev7.1.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.0/dev7.1.0.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.0/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.1/dev7.1.1.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.1/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.2/dev7.1.2.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.2/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.3/dev7.1.3.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.3/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.4/dev7.1.4.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.4/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.5/dev7.1.5.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.5/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.6/dev7.1.6.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.6/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.7/dev7.1.7.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.7/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.8/dev7.1.8.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.8/ata_link
>>
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.9/dev7.1.9.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/link7.1.9/ata_link
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/ata_port
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata7.1/ata_port/ata7.1
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/link8.2/dev8.2.0/ata_device
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/link8.2/ata_link
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/ata_port
>> ./pci0000:00/0000:00:1e.0/0000:05:01.0/ata8.2/ata_port/ata8.2
>>
>> Signed-off-by: David Milburn <dmilburn@redhat.com>
>> ---
>> This could be modified to fit on top of "Insert ATA transport objects in
>> SCSI
>> sysfs topology".
>>
>> drivers/ata/libata-core.c | 6 ++++--
>> drivers/ata/libata-transport.c | 10 +++++-----
>> include/linux/libata.h | 1 +
>> 3 files changed, 10 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 4b6fb48..a796482 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -5629,6 +5629,7 @@ struct ata_port *ata_port_alloc(struct ata_host
>> *host)
>> ap->pflags |= ATA_PFLAG_INITIALIZING | ATA_PFLAG_FROZEN;
>> ap->lock = &host->lock;
>> ap->print_id = -1;
>> + ap->local_print_id = -1;
>> ap->host = host;
>> ap->dev = host->dev;
>> @@ -6119,9 +6120,10 @@ int ata_host_register(struct ata_host *host,
>> struct scsi_host_template *sht)
>> kfree(host->ports[i]);
>> /* give ports names and add SCSI hosts */
>> - for (i = 0; i < host->n_ports; i++)
>> + for (i = 0; i < host->n_ports; i++) {
>> host->ports[i]->print_id =
>> atomic_inc_return(&ata_print_id);
>> -
>> + host->ports[i]->local_print_id = i + 1;
>> + }
>> /* Create associated sysfs transport objects */
>> for (i = 0; i < host->n_ports; i++) {
>> diff --git a/drivers/ata/libata-transport.c
>> b/drivers/ata/libata-transport.c
>> index c04d393..176bed8 100644
>> --- a/drivers/ata/libata-transport.c
>> +++ b/drivers/ata/libata-transport.c
>> @@ -284,7 +284,7 @@ int ata_tport_add(struct device *parent,
>> dev->parent = get_device(parent);
>> dev->release = ata_tport_release;
>> - dev_set_name(dev, "ata%d", ap->print_id);
>> + dev_set_name(dev, "ata%d.%d", ap->print_id, ap->local_print_id);
>> transport_setup_device(dev);
>> error = device_add(dev);
>> if (error) {
>> @@ -410,9 +410,9 @@ int ata_tlink_add(struct ata_link *link)
>> dev->parent = get_device(&ap->tdev);
>> dev->release = ata_tlink_release;
>> if (ata_is_host_link(link))
>> - dev_set_name(dev, "link%d", ap->print_id);
>> + dev_set_name(dev, "link%d.%d", ap->print_id,
>> ap->local_print_id);
>> else
>> - dev_set_name(dev, "link%d.%d", ap->print_id, link->pmp);
>> + dev_set_name(dev, "link%d.%d.%d", ap->print_id,
>> ap->local_print_id, link->pmp);
>> transport_setup_device(dev);
>> @@ -638,9 +638,9 @@ static int ata_tdev_add(struct ata_device *ata_dev)
>> dev->parent = get_device(&link->tdev);
>> dev->release = ata_tdev_release;
>> if (ata_is_host_link(link))
>> - dev_set_name(dev, "dev%d.%d",
>> ap->print_id,ata_dev->devno);
>> + dev_set_name(dev, "dev%d.%d.%d", ap->print_id,
>> ap->local_print_id, ata_dev->devno);
>> else
>> - dev_set_name(dev, "dev%d.%d.0", ap->print_id, link->pmp);
>> + dev_set_name(dev, "dev%d.%d.%d.0", ap->print_id,
>> ap->local_print_id, link->pmp);
>> transport_setup_device(dev);
>> error = device_add(dev);
>> diff --git a/include/linux/libata.h b/include/linux/libata.h
>> index 91c9d10..62d5c1a 100644
>> --- a/include/linux/libata.h
>> +++ b/include/linux/libata.h
>> @@ -745,6 +745,7 @@ struct ata_port {
>> /* Flags that change dynamically, protected by ap->lock */
>> unsigned int pflags; /* ATA_PFLAG_xxx */
>> unsigned int print_id; /* user visible unique port ID
>> */
>> + unsigned int local_print_id; /* host local port ID */
>> unsigned int port_no; /* 0 based port no. inside the
>> host */
>> #ifdef CONFIG_ATA_SFF
>
>
> Hi Jeff, Gwendal, Kay,
>
> Any thoughts on this patch, is this something we could consider for
> 3.9?
Hannes, could you please take a look at this?
We need to find out what the best options are to use to compose
persistent links in /dev/disk/by-path/.
Cheers,
Kay
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH #upstream] libata: export local port number through /sys
2013-02-26 15:26 ` Kay Sievers
@ 2013-03-05 15:48 ` Hannes Reinecke
2013-03-05 23:04 ` David Milburn
0 siblings, 1 reply; 7+ messages in thread
From: Hannes Reinecke @ 2013-03-05 15:48 UTC (permalink / raw)
To: Kay Sievers
Cc: David Milburn, jgarzik, linux-ide, coughlan, fengguang.wu,
gwendal
On 02/26/2013 04:26 PM, Kay Sievers wrote:
> On Mon, Feb 25, 2013 at 10:04 PM, David Milburn <dmilburn@redhat.com> wrote:
>> David Milburn wrote:
>>>
>>> Export <global port>.<local port> format through /sys
>>>
>>> ./pci0000:00/0000:00:1f.2/ata1.1
>>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
>>> ./pci0000:00/0000:00:1f.2/ata2.2
>>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
>>> ./pci0000:00/0000:00:1f.2/ata3.3
>>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
>>> ./pci0000:00/0000:00:1f.2/ata4.4
>>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
>>> ./pci0000:00/0000:00:1f.2/ata5.5
>>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
>>> ./pci0000:00/0000:00:1f.2/ata6.6
>>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
>>>
Hmm.
Can't say I like the 'global port' notation.
Personally I would prefer to have a sysfs attribute for the local
port number, and have path_id get it from there.
For 95% of all cases the above is just an information duplication
(ie it'll only provide a real value for udev, but not for the user).
So, please, use a sysfs attribute for the local port and keep the
numbering as it is.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH #upstream] libata: export local port number through /sys
2013-03-05 15:48 ` Hannes Reinecke
@ 2013-03-05 23:04 ` David Milburn
2013-03-06 7:10 ` Hannes Reinecke
0 siblings, 1 reply; 7+ messages in thread
From: David Milburn @ 2013-03-05 23:04 UTC (permalink / raw)
To: Hannes Reinecke
Cc: linux-ide, jgarzik, kay, coughlan, fengguang.wu, gwendal,
dmilburn
On Tue, Mar 05, 2013 at 04:48:32PM +0100, Hannes Reinecke wrote:
> On 02/26/2013 04:26 PM, Kay Sievers wrote:
> >On Mon, Feb 25, 2013 at 10:04 PM, David Milburn <dmilburn@redhat.com>
> >wrote:
> >>David Milburn wrote:
> >>>
> >>>Export <global port>.<local port> format through /sys
> >>>
> >>>./pci0000:00/0000:00:1f.2/ata1.1
> >>>./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
> >>>./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
> >>>./pci0000:00/0000:00:1f.2/ata1.1/ata_port
> >>>./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
> >>>./pci0000:00/0000:00:1f.2/ata2.2
> >>>./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
> >>>./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
> >>>./pci0000:00/0000:00:1f.2/ata2.2/ata_port
> >>>./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
> >>>./pci0000:00/0000:00:1f.2/ata3.3
> >>>./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
> >>>./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
> >>>./pci0000:00/0000:00:1f.2/ata3.3/ata_port
> >>>./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
> >>>./pci0000:00/0000:00:1f.2/ata4.4
> >>>./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
> >>>./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
> >>>./pci0000:00/0000:00:1f.2/ata4.4/ata_port
> >>>./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
> >>>./pci0000:00/0000:00:1f.2/ata5.5
> >>>./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
> >>>./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
> >>>./pci0000:00/0000:00:1f.2/ata5.5/ata_port
> >>>./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
> >>>./pci0000:00/0000:00:1f.2/ata6.6
> >>>./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
> >>>./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
> >>>./pci0000:00/0000:00:1f.2/ata6.6/ata_port
> >>>./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
> >>>
> Hmm.
>
> Can't say I like the 'global port' notation.
> Personally I would prefer to have a sysfs attribute for the local
> port number, and have path_id get it from there.
>
> For 95% of all cases the above is just an information duplication
> (ie it'll only provide a real value for udev, but not for the user).
>
> So, please, use a sysfs attribute for the local port and keep the
> numbering as it is.
Hi Hannes,
Thanks for your feedback.
Would this patch be acceptable to everyone?
Thanks,
David
---
drivers/ata/libata-core.c | 6 ++++--
drivers/ata/libata-transport.c | 4 +++-
include/linux/libata.h | 1 +
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 497adea..82135b1 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5632,6 +5632,7 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
ap->pflags |= ATA_PFLAG_INITIALIZING | ATA_PFLAG_FROZEN;
ap->lock = &host->lock;
ap->print_id = -1;
+ ap->local_port_no = -1;
ap->host = host;
ap->dev = host->dev;
@@ -6122,9 +6123,10 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
kfree(host->ports[i]);
/* give ports names and add SCSI hosts */
- for (i = 0; i < host->n_ports; i++)
+ for (i = 0; i < host->n_ports; i++) {
host->ports[i]->print_id = atomic_inc_return(&ata_print_id);
-
+ host->ports[i]->local_port_no = i + 1;
+ }
/* Create associated sysfs transport objects */
for (i = 0; i < host->n_ports; i++) {
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
index c04d393..e3808b9 100644
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -37,7 +37,7 @@
#include "libata.h"
#include "libata-transport.h"
-#define ATA_PORT_ATTRS 2
+#define ATA_PORT_ATTRS 3
#define ATA_LINK_ATTRS 3
#define ATA_DEV_ATTRS 9
@@ -216,6 +216,7 @@ static DEVICE_ATTR(name, S_IRUGO, show_ata_port_##name, NULL)
ata_port_simple_attr(nr_pmp_links, nr_pmp_links, "%d\n", int);
ata_port_simple_attr(stats.idle_irq, idle_irq, "%ld\n", unsigned long);
+ata_port_simple_attr(local_port_no, local_port_no, "%u\n", unsigned int);
static DECLARE_TRANSPORT_CLASS(ata_port_class,
"ata_port", NULL, NULL, NULL);
@@ -709,6 +710,7 @@ struct scsi_transport_template *ata_attach_transport(void)
count = 0;
SETUP_PORT_ATTRIBUTE(nr_pmp_links);
SETUP_PORT_ATTRIBUTE(idle_irq);
+ SETUP_PORT_ATTRIBUTE(local_port_no);
BUG_ON(count > ATA_PORT_ATTRS);
i->port_attrs[count] = NULL;
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 91c9d10..5bcbbc5 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -745,6 +745,7 @@ struct ata_port {
/* Flags that change dynamically, protected by ap->lock */
unsigned int pflags; /* ATA_PFLAG_xxx */
unsigned int print_id; /* user visible unique port ID */
+ unsigned int local_port_no; /* user visible host local port ID */
unsigned int port_no; /* 0 based port no. inside the host */
#ifdef CONFIG_ATA_SFF
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH #upstream] libata: export local port number through /sys
2013-03-05 23:04 ` David Milburn
@ 2013-03-06 7:10 ` Hannes Reinecke
0 siblings, 0 replies; 7+ messages in thread
From: Hannes Reinecke @ 2013-03-06 7:10 UTC (permalink / raw)
To: David Milburn; +Cc: linux-ide, jgarzik, kay, coughlan, fengguang.wu, gwendal
On 03/06/2013 12:04 AM, David Milburn wrote:
> On Tue, Mar 05, 2013 at 04:48:32PM +0100, Hannes Reinecke wrote:
>> On 02/26/2013 04:26 PM, Kay Sievers wrote:
>>> On Mon, Feb 25, 2013 at 10:04 PM, David Milburn <dmilburn@redhat.com>
>>> wrote:
>>>> David Milburn wrote:
>>>>>
>>>>> Export <global port>.<local port> format through /sys
>>>>>
>>>>> ./pci0000:00/0000:00:1f.2/ata1.1
>>>>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
>>>>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
>>>>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port
>>>>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
>>>>> ./pci0000:00/0000:00:1f.2/ata2.2
>>>>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
>>>>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
>>>>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port
>>>>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
>>>>> ./pci0000:00/0000:00:1f.2/ata3.3
>>>>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
>>>>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
>>>>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port
>>>>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
>>>>> ./pci0000:00/0000:00:1f.2/ata4.4
>>>>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
>>>>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
>>>>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port
>>>>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
>>>>> ./pci0000:00/0000:00:1f.2/ata5.5
>>>>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
>>>>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
>>>>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port
>>>>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
>>>>> ./pci0000:00/0000:00:1f.2/ata6.6
>>>>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
>>>>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
>>>>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port
>>>>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
>>>>>
>> Hmm.
>>
>> Can't say I like the 'global port' notation.
>> Personally I would prefer to have a sysfs attribute for the local
>> port number, and have path_id get it from there.
>>
>> For 95% of all cases the above is just an information duplication
>> (ie it'll only provide a real value for udev, but not for the user).
>>
>> So, please, use a sysfs attribute for the local port and keep the
>> numbering as it is.
>
> Hi Hannes,
>
> Thanks for your feedback.
>
> Would this patch be acceptable to everyone?
>
I would prefer having it named 'port_no' instead of 'local_port_no'.
Other than that the patch is exactly what I had in mind.
Thanks.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-06 7:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 17:52 [PATCH #upstream] libata: export local port number through /sys David Milburn
2013-02-25 21:04 ` David Milburn
2013-02-25 21:16 ` Jeff Garzik
2013-02-26 15:26 ` Kay Sievers
2013-03-05 15:48 ` Hannes Reinecke
2013-03-05 23:04 ` David Milburn
2013-03-06 7:10 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox