Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

[Bartlomiej Zolnierkiewicz]

Hi,

Please remember to include linux-ide@vger.kernel.org on CC: for ATA patches.

Also from the quick look it seems that:
- patch #4 ("ata: Add APM X-Gene SATA serdes functions") should come before
  patch #3 ("ata: Add APM X-Gene SATA driver") as code in patch #3 depends
  on the code in patch #4
- patch #5 ("Documentation: Add documentation for APM X-Gene SATA DTS
  binding") should come before patch #2 ("arm64: Add APM X-Gene DTS entry
  for SATA controllers") or (even better) just be merged into patch #2

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

On Saturday, November 09, 2013 12:00:26 AM Loc Ho wrote:
> ata: Add APM X-Gene SATA controller support
> 
> v2:
>  * Clean up file sata_xgene.c with Lindent and etc
>  * Clean up file sata_xgene_serdes.c with Lindent and etc
>  * Add description to each patch
> 
> v1:
>  * inital version
> 
> Signed-off-by: Loc Ho <lho@apm.com>
> Signed-off-by: Tuan Phan <tphan@apm.com>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
> Loc Ho (5):
>   ata: Export AHCI library functions required by APM X-Gene SATA driver
>   arm64: Add APM X-Gene DTS entry for SATA controllers
>   ata: Add APM X-Gene SATA driver
>   ata: Add APM X-Gene SATA serdes functions
>   Documentation: Add documentation for APM X-Gene SATA DTS binding
> 
>  .../devicetree/bindings/ata/apm-xgene.txt          |   84 +
>  arch/arm64/boot/dts/apm-storm.dtsi                 |   73 +
>  drivers/ata/Kconfig                                |    7 +
>  drivers/ata/Makefile                               |    2 +
>  drivers/ata/ahci.h                                 |    6 +
>  drivers/ata/libahci.c                              |   13 +-
>  drivers/ata/sata_xgene.c                           | 1394 ++++++++++++++
>  drivers/ata/sata_xgene.h                           |  112 ++
>  drivers/ata/sata_xgene_serdes.c                    | 2004 ++++++++++++++++++++
>  9 files changed, 3690 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/ata/apm-xgene.txt
>  create mode 100644 drivers/ata/sata_xgene.c
>  create mode 100644 drivers/ata/sata_xgene.h
>  create mode 100644 drivers/ata/sata_xgene_serdes.c
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

[Sergei Shtylyov]

Hello.

On 12-11-2013 19:40, Bartlomiej Zolnierkiewicz wrote:

> Please remember to include linux-ide@vger.kernel.org on CC: for ATA patches.

> Also from the quick look it seems that:
> - patch #4 ("ata: Add APM X-Gene SATA serdes functions") should come before
>    patch #3 ("ata: Add APM X-Gene SATA driver") as code in patch #3 depends
>    on the code in patch #4
> - patch #5 ("Documentation: Add documentation for APM X-Gene SATA DTS
>    binding") should come before patch #2 ("arm64: Add APM X-Gene DTS entry
>    for SATA controllers") or (even better) just be merged into patch #2

    No, if it has to be merged then to the driver patch, not .dts patch.

> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics

WBR, Sergei

Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

[Bartlomiej Zolnierkiewicz]

Hi Sergei,

On Tuesday, November 12, 2013 08:34:36 PM Sergei Shtylyov wrote:
> Hello.
> 
> On 12-11-2013 19:40, Bartlomiej Zolnierkiewicz wrote:
> 
> > Please remember to include linux-ide@vger.kernel.org on CC: for ATA patches.
> 
> > Also from the quick look it seems that:
> > - patch #4 ("ata: Add APM X-Gene SATA serdes functions") should come before
> >    patch #3 ("ata: Add APM X-Gene SATA driver") as code in patch #3 depends
> >    on the code in patch #4
> > - patch #5 ("Documentation: Add documentation for APM X-Gene SATA DTS
> >    binding") should come before patch #2 ("arm64: Add APM X-Gene DTS entry
> >    for SATA controllers") or (even better) just be merged into patch #2
> 
>     No, if it has to be merged then to the driver patch, not .dts patch.

Oh, yes.  Driver patch is where these bindings are actually introduced.

Also .dts patch (adding actual users of bindings) should ideally come last.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics