From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ata: pata_hpt37x: disable primary channel on HPT371
Date: Tue, 22 Feb 2022 12:48:09 +0300 [thread overview]
Message-ID: <6604b1f6-adcf-96f6-f736-4ade3642f6f7@omp.ru> (raw)
In-Reply-To: <feb0d6ba-baa2-6482-e6b4-eb5baed2a728@opensource.wdc.com>
On 2/22/22 3:37 AM, Damien Le Moal wrote:
>> HPT371 chips physically have only one channel, the secondary one, however
>> the primary channel registers do exist! Thus we have to manually disable
>> the non-existing channel (if the BIOS hasn't done this already). Alan Cox
>> has only added such code to the 'pata_hpt3x2n' driver, forgetting about
>> this one... :-/
>
> No need to assign blame by name :) Something more neutral like:
>
> "Similarly to the pata_hpt3x2n driver, always disable the primary channel."
Should I now repost?
> will do. Also, do you have a fixes tag for this one ? Is it again:
>
> Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers.")> ?
Yes.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-02-22 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 17:44 [PATCH] ata: pata_hpt37x: disable primary channel on HPT371 Sergey Shtylyov
2022-02-22 0:37 ` Damien Le Moal
2022-02-22 9:48 ` Sergey Shtylyov [this message]
2022-02-22 11:29 ` Damien Le Moal
2022-02-23 0:43 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6604b1f6-adcf-96f6-f736-4ade3642f6f7@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox