From: Damien Le Moal <dlemoal@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ata: sata_dwc_460ex: use platform_get_irq()
Date: Tue, 30 Jun 2026 18:00:46 +0900 [thread overview]
Message-ID: <743a2748-a458-4e65-a1d2-f54a6657e7a6@kernel.org> (raw)
In-Reply-To: <CAKxU2N_2N0YWBrF1k82qXCYYyvZxa26GYi09xiyKbBAtUoC_mA@mail.gmail.com>
On 6/30/26 17:52, Rosen Penev wrote:
>>> Inside ifdef, that is probably why Sashiko did not catch this new warning.
>>>
>>> Rosen, I suggest that you use dev->of_node directly within the ifdef, and drop the local np variable.
>> device_property_present is probably better. But yeah. I'll whip up a v2.
> thinking about this some more. Should use IS_ENABLED to prevent hiding
> this code from the compiler.
What code are you talking about ?
What is in the #ifdef CONFIG_SATA_DWC_OLD_DMA ?
CONFIG_SATA_DWC_OLD_DMA is determined automatically by Kconfig. So this is not
hidding anything and why I did not see the warning in my compile tests
(CONFIG_SATA_DWC_OLD_DMA was enabled for me). The report was for Sparc, and
CONFIG_SATA_DWC_OLD_DMA was disabled so the unused variable warning showed up.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-06-30 9:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 23:03 [PATCH] ata: sata_dwc_460ex: use platform_get_irq() Rosen Penev
2026-06-28 23:12 ` sashiko-bot
2026-06-29 8:21 ` Niklas Cassel
2026-06-29 23:58 ` Damien Le Moal
2026-06-30 7:41 ` Niklas Cassel
2026-06-30 8:21 ` Damien Le Moal
2026-06-30 8:30 ` Niklas Cassel
2026-06-30 8:33 ` Rosen Penev
2026-06-30 8:52 ` Rosen Penev
2026-06-30 9:00 ` Damien Le Moal [this message]
2026-06-30 9:06 ` Niklas Cassel
2026-06-30 9:22 ` Damien Le Moal
2026-06-30 9:55 ` Niklas Cassel
2026-06-30 10:06 ` Damien Le Moal
2026-06-30 11:16 ` Niklas Cassel
2026-06-30 20:11 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743a2748-a458-4e65-a1d2-f54a6657e7a6@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox