From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Jilin Yuan <yuanjilin@cdjrlc.com>,
s.shtylyov@omp.ru
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/ata: fix repeated words in comments
Date: Mon, 11 Jul 2022 08:11:59 +0900 [thread overview]
Message-ID: <81f7fc52-1adf-a26b-3f43-5fdf975ee57c@opensource.wdc.com> (raw)
In-Reply-To: <cec12e246d7151f6041bf553629a3047e81d4afe.camel@HansenPartnership.com>
On 7/10/22 23:21, James Bottomley wrote:
> On Sun, 2022-07-10 at 13:22 +0800, Jilin Yuan wrote:
>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>> index 3307ed45fe4d..f2ac8340e769 100644
>> --- a/drivers/ata/libata-eh.c
>> +++ b/drivers/ata/libata-eh.c
>> @@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list
>> *t)
>> *
>> * Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
>> * is non-zero and EH wasn't pending before. Fast drain ensures
>> - * that EH kicks in in timely manner.
>> + * that EH kicks in timely manner.
>
> The original is correct and the update doesn't make sense. Of course
> adding an article would make the original read better ...
yep: ...that EH kicks in in a timely manner.
>
> James
>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-07-10 23:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 5:22 [PATCH] drivers/ata: fix repeated words in comments Jilin Yuan
2022-07-10 14:21 ` James Bottomley
2022-07-10 23:11 ` Damien Le Moal [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-25 12:36 Jilin Yuan
2022-08-25 22:27 ` Damien Le Moal
2022-09-08 12:48 wangjianli
2022-09-08 12:49 wangjianli
2022-09-08 12:56 ` Conor.Dooley
2022-09-08 13:02 ` James Bottomley
2022-09-08 13:09 ` Conor.Dooley
2022-09-08 14:03 ` James Bottomley
2022-09-10 8:24 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81f7fc52-1adf-a26b-3f43-5fdf975ee57c@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox