From: <Conor.Dooley@microchip.com>
To: <wangjianli@cdjrlc.com>, <damien.lemoal@opensource.wdc.com>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/ata: fix repeated words in comments
Date: Thu, 8 Sep 2022 12:56:48 +0000 [thread overview]
Message-ID: <e2f882f7-6871-a754-fbbd-6a5201f45f4a@microchip.com> (raw)
In-Reply-To: <20220908124937.25962-1-wangjianli@cdjrlc.com>
On 08/09/2022 13:49, wangjianli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Delete the redundant word 'in'.
>
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
> drivers/ata/libata-eh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7c128c89b454..ca865a95cf24 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
> *
> * Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
> * is non-zero and EH wasn't pending before. Fast drain ensures
> - * that EH kicks in in timely manner.
> + * that EH kicks in timely manner.
Hey wangjianli,
This does not look like the right fix to me.. To me, it looks like it
should be s/in in/in in a/.
If you're using an automated tool, which I can only assume you are,
to find these typos it'd be a good idea to check the output for
correctness prior to sending patches.
Thanks,
Conor.
> *
> * LOCKING:
> * spin_lock_irqsave(host lock)
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-09-08 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 12:49 [PATCH] drivers/ata: fix repeated words in comments wangjianli
2022-09-08 12:56 ` Conor.Dooley [this message]
2022-09-08 13:02 ` James Bottomley
2022-09-08 13:09 ` Conor.Dooley
2022-09-08 14:03 ` James Bottomley
2022-09-10 8:24 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2022-09-08 12:48 wangjianli
2022-08-25 12:36 Jilin Yuan
2022-08-25 22:27 ` Damien Le Moal
2022-07-10 5:22 Jilin Yuan
2022-07-10 14:21 ` James Bottomley
2022-07-10 23:11 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f882f7-6871-a754-fbbd-6a5201f45f4a@microchip.com \
--to=conor.dooley@microchip.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangjianli@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox