Re: [PATCH v2] ahci: asm1064: correct count of reported ports

[Niklas Cassel <cassel@kernel.org>]

Hello Andrey,

On Wed, Feb 14, 2024 at 08:24:25PM +0300, Andrey Melnikov wrote:
> ср, 14 февр. 2024 г. в 19:58, Niklas Cassel <cassel@kernel.org>:
> >
> > From: "Andrey Jr. Melnikov" <temnota.am@gmail.com>
> >
> > The ASM1064 SATA host controller always reports wrongly,
> > that it has 24 ports. But in reality, it only has four ports.
> >
> > before:
> > ahci 0000:04:00.0: SSS flag set, parallel bus scan disabled
> > ahci 0000:04:00.0: AHCI 0001.0301 32 slots 24 ports 6 Gbps 0xffff0f impl SATA mode
> > ahci 0000:04:00.0: flags: 64bit ncq sntf stag pm led only pio sxs deso sadm sds apst
> >
> > after:
> > ahci 0000:04:00.0: ASM1064 has only four ports
> > ahci 0000:04:00.0: forcing port_map 0xffff0f -> 0xf
> > ahci 0000:04:00.0: SSS flag set, parallel bus scan disabled
> > ahci 0000:04:00.0: AHCI 0001.0301 32 slots 24 ports 6 Gbps 0xf impl SATA mode
> > ahci 0000:04:00.0: flags: 64bit ncq sntf stag pm led only pio sxs deso sadm sds apst
> >
> > Signed-off-by: Andrey Jr. Melnikov <temnota.am@gmail.com>
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
> > Changes since V1: use switch case.
> 
> I think we should stop abusing saved_port_map and convert all quirk's
> to use mask_port_map.

That sounds like a great idea to me.
Do you plan to send some patches?

If so, I could hold off this patch until I get something from you.


Kind regards,
Niklas