From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Andrey Jr. Melnikov" <temnota.am@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ahci: asm1064: correct count of reported ports
Date: Mon, 19 Feb 2024 10:30:07 +0100 [thread overview]
Message-ID: <ZdMfn5bp19qd3vft@x1-carbon> (raw)
In-Reply-To: <20240214165758.986896-1-cassel@kernel.org>
On Wed, Feb 14, 2024 at 05:57:57PM +0100, Niklas Cassel wrote:
> From: "Andrey Jr. Melnikov" <temnota.am@gmail.com>
>
> The ASM1064 SATA host controller always reports wrongly,
> that it has 24 ports. But in reality, it only has four ports.
>
> before:
> ahci 0000:04:00.0: SSS flag set, parallel bus scan disabled
> ahci 0000:04:00.0: AHCI 0001.0301 32 slots 24 ports 6 Gbps 0xffff0f impl SATA mode
> ahci 0000:04:00.0: flags: 64bit ncq sntf stag pm led only pio sxs deso sadm sds apst
>
> after:
> ahci 0000:04:00.0: ASM1064 has only four ports
> ahci 0000:04:00.0: forcing port_map 0xffff0f -> 0xf
> ahci 0000:04:00.0: SSS flag set, parallel bus scan disabled
> ahci 0000:04:00.0: AHCI 0001.0301 32 slots 24 ports 6 Gbps 0xf impl SATA mode
> ahci 0000:04:00.0: flags: 64bit ncq sntf stag pm led only pio sxs deso sadm sds apst
>
> Signed-off-by: Andrey Jr. Melnikov <temnota.am@gmail.com>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
While I agree with Andrey that we should change the quirks that use
saved_port_map to instead use force_port_map (so that we don't have
two different ways to apply port_map quirks), that clean up can be
done on top of this fix.
---
Applied:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-6.8-fixes
next prev parent reply other threads:[~2024-02-19 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 16:57 [PATCH v2] ahci: asm1064: correct count of reported ports Niklas Cassel
2024-02-14 17:24 ` Andrey Melnikov
2024-02-14 18:13 ` Niklas Cassel
2024-02-19 9:30 ` Niklas Cassel [this message]
2024-02-19 10:37 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdMfn5bp19qd3vft@x1-carbon \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=temnota.am@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox