Asmedia 0x0624 support in linux kernel - request - txt format

Asmedia 0x0624 support in linux kernel - request - txt format

[Pongrácz István]

Dear Tejun/All,

EDIT: sorry, the first email sent as html, now this is a clean txt
version of it. Sorry again.

----

I checked the ahci.c after I failed to use Asmedia sata card (pci:1b21-
0624-1b21-1060;01-01-85;detected;storage;pata_acpi;ASMedia Technology
Inc.;IDE interface;ASMedia Technology Inc.) in linux, using
kernel 5.11.0-37-lowlatency.

As I found no answer/solution on the net, as a final resort I write to
you about this card and try to ask you to look after this chip.

Technically this pci sata card is a 10 ports card, using (as I can see)
3 chips in cascade to get 2x5 sata ports.

Regarding to the recent Asmedia support, I found this: 
https://github.com/torvalds/linux/blob/master/drivers/ata/ahci.c#L588

	/* Asmedia */
	{ PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },	/* ASM1060 */
	{ PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },	/* ASM1060 */
	{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },	/* ASM1061 */
	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */


So, unfortunately the 0624 is not there yet.

Thank you all for your time an efforts regarding the development!

Best regards,
Mr. István Pongrácz

Re: Asmedia 0x0624 support in linux kernel - request - update with manually built kernel

[Pongrácz István]

Dear Tejun/All,

I just downloaded the ubuntu kernel source version 5.4.140 and I
modified the ahci.c file:

I simply added the extra line with the pci id of the card as shown
below:
 
	/* Asmedia */
 	{ PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },	/* ASM1060 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },	/* ASM1060 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },	/* ASM1061 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
 	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
+ 	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, 



I built the kernel and rebooted the machine.
Now the kernel can see disks attached to the card.
As I just drop some hdds I had around, it seems I got some non-working
hdds, so, I will have to get some proven working hdds to populate all
the 10 sata channels and test them.

Summary: at this point it seems with the modification above this card
could work.

If you need something I should do (test), please let me know, I would
be happy to participate in this test.

Thank you.

István Pongrácz






2021. 10.  5, kedd keltezéssel 10.27-kor Pongrácz István ezt írta:
> Dear Tejun/All,
> 
> EDIT: sorry, the first email sent as html, now this is a clean txt
> version of it. Sorry again.
> 
> ----
> 
> I checked the ahci.c after I failed to use Asmedia sata card
> (pci:1b21-
> 0624-1b21-1060;01-01-85;detected;storage;pata_acpi;ASMedia Technology
> Inc.;IDE interface;ASMedia Technology Inc.) in linux, using
> kernel 5.11.0-37-lowlatency.
> 
> As I found no answer/solution on the net, as a final resort I write
> to
> you about this card and try to ask you to look after this chip.
> 
> Technically this pci sata card is a 10 ports card, using (as I can
> see)
> 3 chips in cascade to get 2x5 sata ports.
> 
> Regarding to the recent Asmedia support, I found this: 
> https://github.com/torvalds/linux/blob/master/drivers/ata/ahci.c#L588
> 
> 
> 	/* Asmedia */
> 	{ PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },	/* ASM1060 */
> 	{ PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },	/* ASM1060 */
> 	{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },	/* ASM1061 */
> 	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
> 	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
> 	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
> 
> 
> So, unfortunately the 0624 is not there yet.
> 
> Thank you all for your time an efforts regarding the development!
> 
> Best regards,
> Mr. István Pongrácz

Re: Asmedia 0x0624 support in linux kernel - request - update with manually built kernel

[Tejun Heo]

On Tue, Oct 05, 2021 at 02:58:31PM +0200, Pongrácz István wrote:
> Dear Tejun/All,
> 
> I just downloaded the ubuntu kernel source version 5.4.140 and I
> modified the ahci.c file:
> 
> I simply added the extra line with the pci id of the card as shown
> below:
>  
> 	/* Asmedia */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },	/* ASM1060 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },	/* ASM1060 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },	/* ASM1061 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
> + 	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, 
> 
> 
> 
> I built the kernel and rebooted the machine.
> Now the kernel can see disks attached to the card.
> As I just drop some hdds I had around, it seems I got some non-working
> hdds, so, I will have to get some proven working hdds to populate all
> the 10 sata channels and test them.
> 
> Summary: at this point it seems with the modification above this card
> could work.
> 
> If you need something I should do (test), please let me know, I would
> be happy to participate in this test.

Looks like you're on the right path. Once you're happy with the result, can
you please submit the above as a signed-off patch?

Thank you.

-- 
tejun

Re: Asmedia 0x0624 support in linux kernel - news, test results

[Pongrácz István]

2021. 10.  5, kedd keltezéssel 06.12-kor Tejun Heo ezt írta:
> On Tue, Oct 05, 2021 at 02:58:31PM +0200, Pongrácz István wrote:
> > Dear Tejun/All,
> > 
> > I just downloaded the ubuntu kernel source version 5.4.140 and I
> > modified the ahci.c file:
> > 
> > I simply added the extra line with the pci id of the card as shown
> > below:
> >  
> > 	/* Asmedia */
> >  	{ PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },	/* ASM1060 */
> >  	{ PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },	/* ASM1060 */
> >  	{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },	/* ASM1061 */
> >  	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
> >  	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
> >  	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
> > + 	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, 
> > 
> > 
> > 
> > I built the kernel and rebooted the machine.
> > Now the kernel can see disks attached to the card.
> > As I just drop some hdds I had around, it seems I got some non-working
> > hdds, so, I will have to get some proven working hdds to populate all
> > the 10 sata channels and test them.
> > 
> > Summary: at this point it seems with the modification above this card
> > could work.
> > 
> > If you need something I should do (test), please let me know, I would
> > be happy to participate in this test.
> 
> Looks like you're on the right path. Once you're happy with the result, can
> you please submit the above as a signed-off patch?
> 
> Thank you.

Hi,

An update about my test, short version:
- I had to change my power supply to be able to feed all hdds
- I have 2 pieces of 10 sata ports cards + motherboard 2
- I installed win10 + asmedia driver provided with the card on a mini
CD -> working.
- I installed linuxmint 20.2 Mate and kernel source 5.4.140
- I added the extra line to the ahci.c as shown above and compiled the
kernel, installed etc.
- with the new kernel, the system started and recognised all the hdds
attached to the cards (2x7 HDDs)

My result after about 24 hours of running, these cards are working
well.

Only one small thing I found, besides of ahci, pata_acpi still visible
 as used kernel modules under the card.
I have no idea, is it ok or not or how to remove pata_acpi if
necessary.

02:00.0 IDE interface: ASMedia Technology Inc. Device 0624 (rev 01)
(prog-if 85 [PCI native mode-only controller, supports bus mastering])
	Subsystem: ASMedia Technology Inc. Device 1060
	Flags: bus master, fast devsel, latency 0, IRQ 126
	I/O ports at d040 [size=8]
	I/O ports at d030 [size=4]
	I/O ports at d020 [size=8]
	I/O ports at d010 [size=4]
	I/O ports at d000 [size=16]
	Memory at 91280000 (32-bit, non-prefetchable) [size=8K]
	Expansion ROM at 91200000 [disabled] [size=512K]
	Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit-
	Capabilities: [78] Power Management version 3
	Capabilities: [80] Express Legacy Endpoint, MSI 00
	Capabilities: [100] Virtual Channel
	Capabilities: [800] Advanced Error Reporting
	Kernel driver in use: ahci
	Kernel modules: ahci, pata_acpi

04:00.0 IDE interface: ASMedia Technology Inc. Device 0624 (rev 01)
(prog-if 85 [PCI native mode-only controller, supports bus mastering])
	Subsystem: ASMedia Technology Inc. Device 1060
	Flags: bus master, fast devsel, latency 0, IRQ 127
	I/O ports at c040 [size=8]
	I/O ports at c030 [size=4]
	I/O ports at c020 [size=8]
	I/O ports at c010 [size=4]
	I/O ports at c000 [size=16]
	Memory at 91180000 (32-bit, non-prefetchable) [size=8K]
	Expansion ROM at 91100000 [disabled] [size=512K]
	Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit-
	Capabilities: [78] Power Management version 3
	Capabilities: [80] Express Legacy Endpoint, MSI 00
	Capabilities: [100] Virtual Channel
	Capabilities: [800] Advanced Error Reporting
	Kernel driver in use: ahci
	Kernel modules: ahci, pata_acpi


Anyway, I did not find any side effects up to now. 
s.m.a.r.t. is working, ssd/hdd recognised, I already use it with about
13TByte live data (so, software uses these data files on disks without
problem etc.).

So far so good.

@Tejun, I am not a kernel developer, so, not really clear where to send
the "patch" and for which kernel version :)

Thanks,
István

Re: Asmedia 0x0624 support in linux kernel - news, test results

[Damien Le Moal]

On 2021/10/07 21:05, Pongrácz István wrote:
> 2021. 10.  5, kedd keltezéssel 06.12-kor Tejun Heo ezt írta:
>> On Tue, Oct 05, 2021 at 02:58:31PM +0200, Pongrácz István wrote:
>>> Dear Tejun/All,
>>>
>>> I just downloaded the ubuntu kernel source version 5.4.140 and I
>>> modified the ahci.c file:
>>>
>>> I simply added the extra line with the pci id of the card as shown
>>> below:
>>>  
>>> 	/* Asmedia */
>>>  	{ PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },	/* ASM1060 */
>>>  	{ PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },	/* ASM1060 */
>>>  	{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },	/* ASM1061 */
>>>  	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
>>>  	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
>>>  	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
>>> + 	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, 

Similarly to the other entries above your addition, please add a comment at the
end of the line mentioning the adapter model.

>>>
>>>
>>>
>>> I built the kernel and rebooted the machine.
>>> Now the kernel can see disks attached to the card.
>>> As I just drop some hdds I had around, it seems I got some non-working
>>> hdds, so, I will have to get some proven working hdds to populate all
>>> the 10 sata channels and test them.
>>>
>>> Summary: at this point it seems with the modification above this card
>>> could work.
>>>
>>> If you need something I should do (test), please let me know, I would
>>> be happy to participate in this test.
>>
>> Looks like you're on the right path. Once you're happy with the result, can
>> you please submit the above as a signed-off patch?
>>
>> Thank you.
> 
> Hi,
> 
> An update about my test, short version:
> - I had to change my power supply to be able to feed all hdds
> - I have 2 pieces of 10 sata ports cards + motherboard 2
> - I installed win10 + asmedia driver provided with the card on a mini
> CD -> working.
> - I installed linuxmint 20.2 Mate and kernel source 5.4.140
> - I added the extra line to the ahci.c as shown above and compiled the
> kernel, installed etc.
> - with the new kernel, the system started and recognised all the hdds
> attached to the cards (2x7 HDDs)
> 
> My result after about 24 hours of running, these cards are working
> well.
> 
> Only one small thing I found, besides of ahci, pata_acpi still visible
>  as used kernel modules under the card.
> I have no idea, is it ok or not or how to remove pata_acpi if
> necessary.
> 
> 02:00.0 IDE interface: ASMedia Technology Inc. Device 0624 (rev 01)
> (prog-if 85 [PCI native mode-only controller, supports bus mastering])
> 	Subsystem: ASMedia Technology Inc. Device 1060
> 	Flags: bus master, fast devsel, latency 0, IRQ 126
> 	I/O ports at d040 [size=8]
> 	I/O ports at d030 [size=4]
> 	I/O ports at d020 [size=8]
> 	I/O ports at d010 [size=4]
> 	I/O ports at d000 [size=16]
> 	Memory at 91280000 (32-bit, non-prefetchable) [size=8K]
> 	Expansion ROM at 91200000 [disabled] [size=512K]
> 	Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit-
> 	Capabilities: [78] Power Management version 3
> 	Capabilities: [80] Express Legacy Endpoint, MSI 00
> 	Capabilities: [100] Virtual Channel
> 	Capabilities: [800] Advanced Error Reporting
> 	Kernel driver in use: ahci
> 	Kernel modules: ahci, pata_acpi
> 
> 04:00.0 IDE interface: ASMedia Technology Inc. Device 0624 (rev 01)
> (prog-if 85 [PCI native mode-only controller, supports bus mastering])
> 	Subsystem: ASMedia Technology Inc. Device 1060
> 	Flags: bus master, fast devsel, latency 0, IRQ 127
> 	I/O ports at c040 [size=8]
> 	I/O ports at c030 [size=4]
> 	I/O ports at c020 [size=8]
> 	I/O ports at c010 [size=4]
> 	I/O ports at c000 [size=16]
> 	Memory at 91180000 (32-bit, non-prefetchable) [size=8K]
> 	Expansion ROM at 91100000 [disabled] [size=512K]
> 	Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit-
> 	Capabilities: [78] Power Management version 3
> 	Capabilities: [80] Express Legacy Endpoint, MSI 00
> 	Capabilities: [100] Virtual Channel
> 	Capabilities: [800] Advanced Error Reporting
> 	Kernel driver in use: ahci
> 	Kernel modules: ahci, pata_acpi
> 
> 
> Anyway, I did not find any side effects up to now. 
> s.m.a.r.t. is working, ssd/hdd recognised, I already use it with about
> 13TByte live data (so, software uses these data files on disks without
> problem etc.).
> 
> So far so good.
> 
> @Tejun, I am not a kernel developer, so, not really clear where to send
> the "patch" and for which kernel version :)

write your patch against the latest libata tree available at:

git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git

or

https://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git

And use "git send-email" to send the patch to me and to linux-ide@vger.kernel.org.

Feel free to let me know if you have any problem.

Thanks.

-- 
Damien Le Moal
Western Digital Research

Re: Asmedia 0x0624 support in linux kernel - news, test results

[Pongrácz István]

>>     /* Asmedia */
>>     { PCI_VDEVICE(ASMEDIA, 0x0601), board_ahci },   /* ASM1060 */
>>     { PCI_VDEVICE(ASMEDIA, 0x0602), board_ahci },   /* ASM1060 */
>>     { PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci },   /* ASM1061 */
>>     { PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },   /* ASM1062 */
>>     { PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
>>     { PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
>> +   { PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, 
> Similarly to the other entries above your addition, please add a
> comment at the end of the line mentioning the adapter model.
> And use "git send-email" to send the patch to me and to 
> linux-ide@vger.kernel.org.
> Feel free to let me know if you have any problem.

Hi Damien,

I sent the patch as you requested.
Sorry for the duplicated patch, the first one probably went to the spam
folder.

Bye,
István