* is there a value to CONFIG_NO_ATA_LEGACY?
@ 2008-02-10 19:44 Robert P. J. Day
2008-02-10 22:54 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2008-02-10 19:44 UTC (permalink / raw)
To: linux-ide
in drivers/ata/libata-sff.c:
...
#if defined(CONFIG_NO_ATA_LEGACY)
/* Some platforms with PCI limits cannot address compat
port space. In that case we punt if their firmware has
left a device in compatibility mode */
if (legacy_mode) {
printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
return -EOPNOTSUPP;
}
#endif
...
there is no Kconfig file that defines that variable -- should that
test be removed? or is something eventually coming that defines it?
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
Home page: http://crashcourse.ca
Fedora Cookbook: http://crashcourse.ca/wiki/index.php/Fedora_Cookbook
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: is there a value to CONFIG_NO_ATA_LEGACY?
2008-02-10 19:44 is there a value to CONFIG_NO_ATA_LEGACY? Robert P. J. Day
@ 2008-02-10 22:54 ` Alan Cox
2008-02-10 23:05 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2008-02-10 22:54 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-ide
On Sun, 10 Feb 2008 14:44:16 -0500 (EST)
"Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
>
> in drivers/ata/libata-sff.c:
>
> ...
> #if defined(CONFIG_NO_ATA_LEGACY)
> /* Some platforms with PCI limits cannot address compat
> port space. In that case we punt if their firmware has
> left a device in compatibility mode */
> if (legacy_mode) {
> printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
> return -EOPNOTSUPP;
> }
> #endif
> ...
>
> there is no Kconfig file that defines that variable -- should that
> test be removed? or is something eventually coming that defines it?
It is used by some of the unsubmitted tree stuff certainly and is there
because some platforms will need it (eg FRV).
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: is there a value to CONFIG_NO_ATA_LEGACY?
2008-02-10 22:54 ` Alan Cox
@ 2008-02-10 23:05 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2008-02-10 23:05 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-ide
On Sun, 10 Feb 2008, Alan Cox wrote:
> On Sun, 10 Feb 2008 14:44:16 -0500 (EST)
> "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
>
> >
> > in drivers/ata/libata-sff.c:
> >
> > ...
> > #if defined(CONFIG_NO_ATA_LEGACY)
> > /* Some platforms with PCI limits cannot address compat
> > port space. In that case we punt if their firmware has
> > left a device in compatibility mode */
> > if (legacy_mode) {
> > printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
> > return -EOPNOTSUPP;
> > }
> > #endif
> > ...
> >
> > there is no Kconfig file that defines that variable -- should that
> > test be removed? or is something eventually coming that defines it?
>
> It is used by some of the unsubmitted tree stuff certainly and is there
> because some platforms will need it (eg FRV).
ok, good enough, i'm just trying to cull my list of unreferenced
Kconfig variables.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
Home page: http://crashcourse.ca
Fedora Cookbook: http://crashcourse.ca/wiki/index.php/Fedora_Cookbook
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-10 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-10 19:44 is there a value to CONFIG_NO_ATA_LEGACY? Robert P. J. Day
2008-02-10 22:54 ` Alan Cox
2008-02-10 23:05 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox