From: Damien Le Moal <dlemoal@kernel.org>
To: Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v3 2/5] ata: libata-scsi: refactor ata_scsi_report_supported_opcodes()
Date: Fri, 3 Jul 2026 16:05:25 +0900 [thread overview]
Message-ID: <e98e05a2-03a9-4b62-ac49-f382ea08c932@kernel.org> (raw)
In-Reply-To: <63c22af2-09df-47ff-a5cd-a9165bf265fc@suse.de>
On 7/3/26 15:44, Hannes Reinecke wrote:
>> + {
>> + .op = MAINTENANCE_IN, .cdb_len = 12,
>> + .sa_valid = true,
>> + .sa = MI_REPORT_SUPPORTED_OPERATION_CODES
>> + },
>> + { .op = SECURITY_PROTOCOL_OUT, .cdb_len = 12 },
>> +};
>> +
>
> What an unusual formatting. I would have gone for multi-line
> entries even for the simple ones to keep formatting the same
> for all entries.
The multi-line for everything made the array really big, and hard to read. After
trying different things, I settled on this.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-07-03 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 4:05 [PATCH v3 0/5] Improve ata_scsi_report_supported_opcodes() Damien Le Moal
2026-07-03 4:05 ` [PATCH v3 1/5] ata: libata: rename ata_dev_is_zac() Damien Le Moal
2026-07-03 4:59 ` sashiko-bot
2026-07-03 6:15 ` Damien Le Moal
2026-07-03 4:05 ` [PATCH v3 2/5] ata: libata-scsi: refactor ata_scsi_report_supported_opcodes() Damien Le Moal
2026-07-03 6:44 ` Hannes Reinecke
2026-07-03 7:05 ` Damien Le Moal [this message]
2026-07-03 7:06 ` Hannes Reinecke
2026-07-03 4:05 ` [PATCH v3 3/5] ata: libata-scsi: improve service action support in ata_scsi_report_supported_opcodes() Damien Le Moal
2026-07-03 4:05 ` [PATCH v3 4/5] ata: libata-scsi: support reporting options 2 in REPORT SUPPORTED OPERATION CODES Damien Le Moal
2026-07-03 4:27 ` sashiko-bot
2026-07-03 4:05 ` [PATCH v3 5/5] ata: libata-scsi: support the all command format for reporting supported commands Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98e05a2-03a9-4b62-ac49-f382ea08c932@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox