From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"daniel.baluta@gmail.com" <daniel.baluta@gmail.com>
Subject: Re: [PATCH 5/6] iio:magn:mmc35240: Drop unnecessary casts of val parameter in regmap_bulk*
Date: Mon, 13 Apr 2020 04:32:35 +0000 [thread overview]
Message-ID: <056ba15c5b62fdbccaeaccf5496b68994a7357fa.camel@analog.com> (raw)
In-Reply-To: <20200405180321.1737310-6-jic23@kernel.org>
On Sun, 2020-04-05 at 19:03 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Given the parameter is void *, casting to u8 * is unnecessary.
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
> drivers/iio/magnetometer/mmc35240.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/mmc35240.c
> b/drivers/iio/magnetometer/mmc35240.c
> index 425cdd07b4e5..1787d656d009 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -239,7 +239,7 @@ static int mmc35240_init(struct mmc35240_data *data)
> return ret;
>
> ret = regmap_bulk_read(data->regmap, MMC35240_OTP_START_ADDR,
> - (u8 *)otp_data, sizeof(otp_data));
> + otp_data, sizeof(otp_data));
> if (ret < 0)
> return ret;
>
> @@ -295,7 +295,7 @@ static int mmc35240_read_measurement(struct mmc35240_data
> *data, __le16 buf[3])
> if (ret < 0)
> return ret;
>
> - return regmap_bulk_read(data->regmap, MMC35240_REG_XOUT_L, (u8 *)buf,
> + return regmap_bulk_read(data->regmap, MMC35240_REG_XOUT_L, buf,
> 3 * sizeof(__le16));
> }
>
next prev parent reply other threads:[~2020-04-13 4:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 18:03 [PATCH 0/6] IIO: Tidy up parameters to regmap_bulk_* calls jic23
2020-04-05 18:03 ` [PATCH 1/6] iio:accel:mxc4005: Drop unnecessary explicit casts in regmap_bulk_read calls jic23
2020-04-13 4:31 ` Ardelean, Alexandru
2020-04-05 18:03 ` [PATCH 2/6] iio:chemical:atlas-sensor: " jic23
2020-04-06 0:54 ` Matt Ranostay
2020-04-05 18:03 ` [PATCH 3/6] iio:chemical:bme680: Tidy up parameters to regmap_bulk_read jic23
2020-04-06 13:08 ` Himanshu Jha
2020-04-05 18:03 ` [PATCH 4/6] iio:imu:mpu6050: Tidy up parameters to regmap_bulk functions jic23
2020-04-13 4:32 ` Ardelean, Alexandru
2020-04-05 18:03 ` [PATCH 5/6] iio:magn:mmc35240: Drop unnecessary casts of val parameter in regmap_bulk* jic23
2020-04-13 4:32 ` Ardelean, Alexandru [this message]
2020-04-05 18:03 ` [PATCH 6/6] iio:light:ltr501: Drop unnecessary cast of parameter in regmap_bulk_read jic23
2020-04-13 4:33 ` Ardelean, Alexandru
2020-04-12 13:48 ` [PATCH 0/6] IIO: Tidy up parameters to regmap_bulk_* calls Jonathan Cameron
2020-04-12 20:59 ` Andy Shevchenko
2020-04-13 4:34 ` Ardelean, Alexandru
2020-04-13 15:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056ba15c5b62fdbccaeaccf5496b68994a7357fa.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox