public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
	"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 0/6] IIO: Tidy up parameters to regmap_bulk_* calls
Date: Mon, 13 Apr 2020 16:07:28 +0100	[thread overview]
Message-ID: <20200413160728.6d3fc867@archlinux> (raw)
In-Reply-To: <6f82392031e95a39a63d9fed87f94961cd8ae12c.camel@analog.com>

On Mon, 13 Apr 2020 04:34:50 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2020-04-12 at 23:59 +0300, Andy Shevchenko wrote:
> > On Sun, Apr 12, 2020 at 4:48 PM Jonathan Cameron
> > <jic23@jic23.retrosnub.co.uk> wrote:  
> > > If anyone is bored and fancies sanity checking the ones in this series
> > > that have had no eyes on them yet, it would be much appreciated!  
> > 
> > The series makes sense to me. Feel free to add my Rb tag to it if you like.
> >   
> 
> Same from my side.
> I added my tag on the patches.
> I waited a bit until some driver authors replied back.
Thanks to both of you!

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> 
> 
> > > On Sun,  5 Apr 2020 19:03:15 +0100
> > > jic23@kernel.org wrote:
> > >   
> > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > 
> > > > One of Andy Shevchenko's recent patches tidied a case of this up
> > > > and a quick grep showed we had some more.
> > > > 
> > > > The main focus of this set is calls to regmap_bulk_read /
> > > > regmap_bulk_write.  Both are used with buffers of many and varied type,
> > > > but as they take a void * there is never any need to cast a pointer
> > > > to said buffers to anything explicitly.
> > > > 
> > > > Whilst I was here I used sizeof(buf) in various places to reduce
> > > > the use of explicit values when we could derive it from the source
> > > > / destination buffer.
> > > > 
> > > > This isn't remotely urgent, but I'd like to clean these out to avoid
> > > > replication in future.  Not I didn't go after any other unnecessary
> > > > casts in the files because that would have take thought and its Sunday
> > > > evening and about time for a beer.
> > > > 
> > > > Jonathan Cameron (6):
> > > >   iio:accel:mxc4005: Drop unnecessary explicit casts in regmap_bulk_read
> > > >     calls
> > > >   iio:chemical:atlas-sensor: Drop unnecessary explicit casts in
> > > >     regmap_bulk_read calls
> > > >   iio:chemical:bme680: Tidy up parameters to regmap_bulk_read
> > > >   iio:imu:mpu6050: Tidy up parameters to regmap_bulk functions.
> > > >   iio:magn:mmc35240: Drop unnecessary casts of val parameter in
> > > >     regmap_bulk*
> > > >   iio:light:ltr501: Drop unnecessary cast of parameter in
> > > >     regmap_bulk_read
> > > > 
> > > >  drivers/iio/accel/mxc4005.c                |  4 +--
> > > >  drivers/iio/chemical/atlas-sensor.c        |  7 ++---
> > > >  drivers/iio/chemical/bme680_core.c         | 36 +++++++++++++---------
> > > >  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c |  4 +--
> > > >  drivers/iio/light/ltr501.c                 |  2 +-
> > > >  drivers/iio/magnetometer/mmc35240.c        |  4 +--
> > > >  6 files changed, 32 insertions(+), 25 deletions(-)
> > > >   
> > 
> >   


      reply	other threads:[~2020-04-13 15:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 18:03 [PATCH 0/6] IIO: Tidy up parameters to regmap_bulk_* calls jic23
2020-04-05 18:03 ` [PATCH 1/6] iio:accel:mxc4005: Drop unnecessary explicit casts in regmap_bulk_read calls jic23
2020-04-13  4:31   ` Ardelean, Alexandru
2020-04-05 18:03 ` [PATCH 2/6] iio:chemical:atlas-sensor: " jic23
2020-04-06  0:54   ` Matt Ranostay
2020-04-05 18:03 ` [PATCH 3/6] iio:chemical:bme680: Tidy up parameters to regmap_bulk_read jic23
2020-04-06 13:08   ` Himanshu Jha
2020-04-05 18:03 ` [PATCH 4/6] iio:imu:mpu6050: Tidy up parameters to regmap_bulk functions jic23
2020-04-13  4:32   ` Ardelean, Alexandru
2020-04-05 18:03 ` [PATCH 5/6] iio:magn:mmc35240: Drop unnecessary casts of val parameter in regmap_bulk* jic23
2020-04-13  4:32   ` Ardelean, Alexandru
2020-04-05 18:03 ` [PATCH 6/6] iio:light:ltr501: Drop unnecessary cast of parameter in regmap_bulk_read jic23
2020-04-13  4:33   ` Ardelean, Alexandru
2020-04-12 13:48 ` [PATCH 0/6] IIO: Tidy up parameters to regmap_bulk_* calls Jonathan Cameron
2020-04-12 20:59   ` Andy Shevchenko
2020-04-13  4:34     ` Ardelean, Alexandru
2020-04-13 15:07       ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200413160728.6d3fc867@archlinux \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox