[PATCH] staging: iio: resolver: ads1210: fix config mode

[PATCH] staging: iio: resolver: ads1210: fix config mode

[Nuno Sá]

As stated in the device datasheet [1], bits a0 and a1 have to be set to
1 for the configuration mode.

[1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad2s1210.pdf

Fixes: b19e9ad5e2cb9 ("staging:iio:resolver:ad2s1210 general driver cleanup")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/staging/iio/resolver/ad2s1210.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index e4cf42438487..636c45b12843 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -101,7 +101,7 @@ struct ad2s1210_state {
 static const int ad2s1210_mode_vals[4][2] = {
 	[MOD_POS] = { 0, 0 },
 	[MOD_VEL] = { 0, 1 },
-	[MOD_CONFIG] = { 1, 0 },
+	[MOD_CONFIG] = { 1, 1 },
 };
 
 static inline void ad2s1210_set_mode(enum ad2s1210_mode mode,
-- 
2.40.0

Re: [PATCH] staging: iio: resolver: ads1210: fix config mode

[Jonathan Cameron]

On Mon, 27 Mar 2023 16:54:14 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> As stated in the device datasheet [1], bits a0 and a1 have to be set to
> 1 for the configuration mode.
> 
> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad2s1210.pdf
> 
> Fixes: b19e9ad5e2cb9 ("staging:iio:resolver:ad2s1210 general driver cleanup")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Oops. Younger more foolish me bug (back in 2011 so I'll cut myself some slack)

Applied to the togreg branch of iio.git (not rushing something in that is in staging
and has been broken a while without anyone commenting!)

I don't suppose this means you are going to get this ready to move out of staging?
*looks hopeful*

Thanks,

Jonathan
 
> ---
>  drivers/staging/iio/resolver/ad2s1210.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index e4cf42438487..636c45b12843 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -101,7 +101,7 @@ struct ad2s1210_state {
>  static const int ad2s1210_mode_vals[4][2] = {
>  	[MOD_POS] = { 0, 0 },
>  	[MOD_VEL] = { 0, 1 },
> -	[MOD_CONFIG] = { 1, 0 },
> +	[MOD_CONFIG] = { 1, 1 },
>  };
>  
>  static inline void ad2s1210_set_mode(enum ad2s1210_mode mode,

Re: [PATCH] staging: iio: resolver: ads1210: fix config mode

[Nuno Sá]

On Sat, 2023-04-01 at 15:24 +0100, Jonathan Cameron wrote:
> On Mon, 27 Mar 2023 16:54:14 +0200
> Nuno Sá <nuno.sa@analog.com> wrote:
> 
> > As stated in the device datasheet [1], bits a0 and a1 have to be
> > set to
> > 1 for the configuration mode.
> > 
> > [1]:
> > https://www.analog.com/media/en/technical-documentation/data-sheets/ad2s1210.pdf
> > 
> > Fixes: b19e9ad5e2cb9 ("staging:iio:resolver:ad2s1210 general driver
> > cleanup")
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> 
> Oops. Younger more foolish me bug (back in 2011 so I'll cut myself
> some slack)
> 
> Applied to the togreg branch of iio.git (not rushing something in
> that is in staging
> and has been broken a while without anyone commenting!)
> 
> I don't suppose this means you are going to get this ready to move
> out of staging?
> *looks hopeful*
> 

Eeheh, Unfortunately not on the top of my list right now... But, if I
happen to find some hardware hanging around, I might eventually get
into it.

Funny enough, this was actually reported to us in one of our support
channels which means there are people actually using the driver even
being it on staging.

- Nuno Sá